LGTM, good luck with the !is_target_set() piece :).
https://codereview.chromium.org/584043002/diff/20001/src/ic/ic.cc
File src/ic/ic.cc (right):
https://codereview.chromium.org/584043002/diff/20001/src/ic/ic.cc#newcode905
src/ic/ic.cc:905: if (kind() == Code::KEYED_LOAD_IC) return;
Maybe a comment here? I'm not sure why keyed stores get to update the
cache, but keyed loads don't.
https://codereview.chromium.org/584043002/diff/20001/src/ic/x64/stub-cache-x64.cc
File src/ic/x64/stub-cache-x64.cc (right):
https://codereview.chromium.org/584043002/diff/20001/src/ic/x64/stub-cache-x64.cc#newcode44
src/ic/x64/stub-cache-x64.cc:44: __ cmpp(name, Operand(kScratchRegister,
offset, scale_factor, 0));
+1, simpler :)
https://codereview.chromium.org/584043002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
