On 2014/10/08 13:34:46, wingo wrote:
https://codereview.chromium.org/633373003/diff/20001/src/ast.h
File src/ast.h (right):
https://codereview.chromium.org/633373003/diff/20001/src/ast.h#newcode187
src/ast.h:187: IdGen() : id_(BailoutId::FirstUsable().ToInt()) {}
What is the plan with bailout ids -- still a per-function locally unique
incrementing integer? For parameter destructuring of arrow functions I
will
have to transplant expressions from one function to another. I'm finally
starting on that now:
https://docs.google.com/document/d/1iJWvuakeKsPJOeA-RJ-4bM3Jha5iewQjxKsylgzHEB0/edit.
The plan was to see if we could add a post-pass to assign bailout ids,
to see
how that would impact perf, because when transplanting you have to
preserve
local uniqueness; but is that still a valid strategy?
Yes, this is still valid. You still need to guarantee uniqueness, but it
does
not have to fill the consecutive range (never had to; I do not know where we
have got the idea that it does)
https://codereview.chromium.org/633373003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
