On 2014/10/09 15:54:57, ulan wrote:
Torne, we usually do not merge back anything except critical bug fixes
that
have
canary coverage. Does this have any coverage?
Could you please explain here why you need this in 3.29 and why it is
safe?
(to
make it easier for me to get L G T M from V8 team).
The people working on doing FDO for the android platform are intending to
start
collecting profiling data and feeding it back into the build on an android
branch that is tracking chromium M39, and V8 is the most critical part of
chromium on which to enable FDO data collection/optimisation. We'll end up
cherrypicking this downstream if it doesn't land in V8 here, but we prefer
to
keep the android branches unforked from upstream if we can.
It should be safe since all it does is introduce the FDO flag into the
generated
makefiles on android webview builds, and the flag on its own does nothing
(since
the FDO data collection/optimisation mode still has to be enabled globally
in
the build, which will only happen for selected release builds). It's
ultimately
up to the FDO compiler guys to test the results there.
https://codereview.chromium.org/644753002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.