LGTM (just one more nit).
https://codereview.chromium.org/633423002/diff/130001/src/compiler/ast-graph-builder.cc
File src/compiler/ast-graph-builder.cc (right):
https://codereview.chromium.org/633423002/diff/130001/src/compiler/ast-graph-builder.cc#newcode1105
src/compiler/ast-graph-builder.cc:1105: int slot =
property->PropertyFeedbackSlot();
nit: Instead of randomly pulling either "slot" or "pair" out into a
local variable, we could uniformly use "pair" everywhere ... then you
upcoming change to the type of "slot" gets easier too. This applies
throughout the file.
https://codereview.chromium.org/633423002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
