Addressed Ross' comment.
https://codereview.chromium.org/643163002/diff/1/tools/gyp/v8.gyp
File tools/gyp/v8.gyp (right):
https://codereview.chromium.org/643163002/diff/1/tools/gyp/v8.gyp#newcode1405
tools/gyp/v8.gyp:1405: [ 'v8_use_external_startup_data==1', {
On 2014/10/10 16:31:33, rmcilroy wrote:
I just had a look at how natives_blob does this, and it looks like it
has the
target unconditionally, but puts the actions in a conditions block
which depends
on 'v8_use_external_startup_data==1'. I think the same thing would
work on
v8_external_snapshot - could we do that instead to keep things
consistent?
Done.
https://codereview.chromium.org/643163002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
