Reviewers: v8-team_google.com, Description: This removes common.gypi from the v8.gyp file, because when building as part of Chrome or O3D, the common.gypi is now "forced" to be included, and this results in duplicate symbols at GYP time on XCode.
I have tested this change with O3D, but not with compiling V8 standalone. Does V8 standalone even use GYP? Please review this at http://codereview.chromium.org/216008 SVN Base: http://v8.googlecode.com/svn/trunk/ Affected files: M tools/gyp/v8.gyp Index: tools/gyp/v8.gyp =================================================================== --- tools/gyp/v8.gyp (revision 2891) +++ tools/gyp/v8.gyp (working copy) @@ -34,9 +34,6 @@ 'v8_use_snapshot%': 'true', 'v8_regexp%': 'native', }, - 'includes': [ - '../../../build/common.gypi', - ], 'target_defaults': { 'defines': [ 'ENABLE_LOGGING_AND_PROFILING', --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
