Comments addressed, landing.
https://codereview.chromium.org/639243003/diff/50001/src/arm/full-codegen-arm.cc
File src/arm/full-codegen-arm.cc (right):
https://codereview.chromium.org/639243003/diff/50001/src/arm/full-codegen-arm.cc#newcode2545
src/arm/full-codegen-arm.cc:2545: __ ldr(scratch2, MemOperand(sp,
kPointerSize)); // value
On 2014/10/13 11:39:07, Igor Sheludko wrote:
I think you could load value directly to r0 and use scratch2 below
instead of
r0. (minus one instruction)
Great suggestion, done
https://codereview.chromium.org/639243003/diff/50001/src/arm64/full-codegen-arm64.cc
File src/arm64/full-codegen-arm64.cc (right):
https://codereview.chromium.org/639243003/diff/50001/src/arm64/full-codegen-arm64.cc#newcode2205
src/arm64/full-codegen-arm64.cc:2205: __ Peek(scratch2, kPointerSize);
// value
On 2014/10/13 11:39:07, Igor Sheludko wrote:
Same note here as for arm.
Done.
https://codereview.chromium.org/639243003/diff/50001/src/ia32/full-codegen-ia32.cc
File src/ia32/full-codegen-ia32.cc (right):
https://codereview.chromium.org/639243003/diff/50001/src/ia32/full-codegen-ia32.cc#newcode2461
src/ia32/full-codegen-ia32.cc:2461: __ mov(scratch2, MemOperand(esp,
kPointerSize)); // value
On 2014/10/13 11:39:07, Igor Sheludko wrote:
Same note here.
Done.
https://codereview.chromium.org/639243003/diff/50001/src/x64/full-codegen-x64.cc
File src/x64/full-codegen-x64.cc (right):
https://codereview.chromium.org/639243003/diff/50001/src/x64/full-codegen-x64.cc#newcode2460
src/x64/full-codegen-x64.cc:2460: __ movp(scratch2, MemOperand(rsp,
kPointerSize)); // value
On 2014/10/13 11:39:07, Igor Sheludko wrote:
And here.
Done.
https://codereview.chromium.org/639243003/diff/50001/test/mjsunit/harmony/super.js
File test/mjsunit/harmony/super.js (right):
https://codereview.chromium.org/639243003/diff/50001/test/mjsunit/harmony/super.js#newcode710
test/mjsunit/harmony/super.js:710:
On 2014/10/13 11:39:07, Igor Sheludko wrote:
Does it make sense to test keyed access via object with toString()
method like
you did for ordinary keyed stores to super?
Done.
https://codereview.chromium.org/639243003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
