Reviewers: marja,
Message:
Here's a patch to move assignment of bailout/feedback IDs to a post-pass.
Some initial perf discussions:
https://groups.google.com/d/msg/v8-dev/zz2YMlxxaKM/OVNJWqvkovEJ
The actual perf on this is a little better than the mail makes it out to be:
486.00M instructions, compared 487.57M instructions with an "empty"
post-pass.
The baseline is 479.55M before the patch.
Time-wise I can't measure in the same way as we need to assign bailout IDs
after
all AST mutations have occurred, so after rewriting and scope analysis.
However
if I run the jquery-parsing-test.js benchmark through d8 with --no-lazy, and
time its runtime using bash's time, do it 100 times and take the best, then
the
"before" time is 0.122s and the "after" time is 0.128s. So still a
regression.
What do you think, Marja? Is this somehow within the realms of possibility?
Description:
Assign bailout and type feedback IDs in a post-pass
This will allow us to move expressions from one function to another, for
example when the parser determines that a given cover grammar instance
is actually the default value initializer for an arrow function.
[email protected]
BUG=
Please review this at https://codereview.chromium.org/636403003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+663, -271 lines):
M BUILD.gn
M src/ast.h
M src/ast.cc
A src/ast-numbering.h
A src/ast-numbering.cc
M src/compiler.h
M src/compiler.cc
M src/compiler/js-inlining.cc
M src/hydrogen.cc
M src/parser.cc
M src/preparser.h
M src/preparser.cc
M src/rewriter.cc
M src/scopes.cc
M test/cctest/compiler/function-tester.h
M test/cctest/compiler/test-codegen-deopt.cc
M test/cctest/compiler/test-pipeline.cc
M test/cctest/test-ast.cc
M test/cctest/test-parsing.cc
M tools/gyp/v8.gyp
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
