Reviewers: Benedikt Meurer, Michael Starzinger,
Message:
Could you take a look, please?
Description:
[turbofan] Use register for instruction operands when SameAsFirst is
specified.
As the register allocator cannot reuse spill slots, SameAsFirst
constraint means that we would have to do an expensive move to a
differen spill slot if we choose to spill. Forcing the operand
to a register is cheaper.
In zlib, we get >10% speed-up for ia32, >25% for x64.
BUG=
Please review this at https://codereview.chromium.org/650083003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+17, -17 lines):
M src/compiler/ia32/instruction-selector-ia32.cc
M src/compiler/instruction-selector-impl.h
M src/compiler/x64/instruction-selector-x64.cc
Index: src/compiler/ia32/instruction-selector-ia32.cc
diff --git a/src/compiler/ia32/instruction-selector-ia32.cc
b/src/compiler/ia32/instruction-selector-ia32.cc
index
dee53c9559fc97c0188f20f41e087963a00e3640..62d29f5110bcd5c7918d719312f3b5d074620121
100644
--- a/src/compiler/ia32/instruction-selector-ia32.cc
+++ b/src/compiler/ia32/instruction-selector-ia32.cc
@@ -260,7 +260,7 @@ static void VisitBinop(InstructionSelector* selector,
Node* node,
// TODO(turbofan): match complex addressing modes.
if (g.CanBeImmediate(right)) {
- inputs[input_count++] = g.Use(left);
+ inputs[input_count++] = g.UseRegister(left);
inputs[input_count++] = g.UseImmediate(right);
} else {
if (node->op()->HasProperty(Operator::kCommutative) &&
@@ -315,7 +315,7 @@ void InstructionSelector::VisitWord32Xor(Node* node) {
IA32OperandGenerator g(this);
Int32BinopMatcher m(node);
if (m.right().Is(-1)) {
- Emit(kIA32Not, g.DefineSameAsFirst(node), g.Use(m.left().node()));
+ Emit(kIA32Not, g.DefineSameAsFirst(node),
g.UseRegister(m.left().node()));
} else {
VisitBinop(this, node, kIA32Xor);
}
@@ -330,7 +330,7 @@ static inline void VisitShift(InstructionSelector*
selector, Node* node,
Node* right = node->InputAt(1);
if (g.CanBeImmediate(right)) {
- selector->Emit(opcode, g.DefineSameAsFirst(node), g.Use(left),
+ selector->Emit(opcode, g.DefineSameAsFirst(node), g.UseRegister(left),
g.UseImmediate(right));
} else {
Int32BinopMatcher m(node);
@@ -340,7 +340,7 @@ static inline void VisitShift(InstructionSelector*
selector, Node* node,
right = mright.left().node();
}
}
- selector->Emit(opcode, g.DefineSameAsFirst(node), g.Use(left),
+ selector->Emit(opcode, g.DefineSameAsFirst(node), g.UseRegister(left),
g.UseFixed(right, ecx));
}
}
Index: src/compiler/instruction-selector-impl.h
diff --git a/src/compiler/instruction-selector-impl.h
b/src/compiler/instruction-selector-impl.h
index
600ac399da7544368b54380e7021d36f8f06eeb4..49ad0918a6e718fe99a6c91bdaff7118911f7717
100644
--- a/src/compiler/instruction-selector-impl.h
+++ b/src/compiler/instruction-selector-impl.h
@@ -55,9 +55,9 @@ class OperandGenerator {
}
InstructionOperand* Use(Node* node) {
- return Use(node,
- new (zone()) UnallocatedOperand(
- UnallocatedOperand::ANY,
UnallocatedOperand::USED_AT_START));
+ return Use(
+ node, new (zone()) UnallocatedOperand(
+ UnallocatedOperand::NONE,
UnallocatedOperand::USED_AT_START));
}
InstructionOperand* UseRegister(Node* node) {
@@ -69,7 +69,7 @@ class OperandGenerator {
// Use register or operand for the node. If a register is chosen, it
won't
// alias any temporary or output registers.
InstructionOperand* UseUnique(Node* node) {
- return Use(node, new (zone())
UnallocatedOperand(UnallocatedOperand::ANY));
+ return Use(node, new (zone())
UnallocatedOperand(UnallocatedOperand::NONE));
}
// Use a unique register for the node that does not alias any temporary
or
Index: src/compiler/x64/instruction-selector-x64.cc
diff --git a/src/compiler/x64/instruction-selector-x64.cc
b/src/compiler/x64/instruction-selector-x64.cc
index
7f9e40afe2c4a2209b929b7d71440968b84576e1..741a3a2e9de8398cb0996fc21ca3866986c083dd
100644
--- a/src/compiler/x64/instruction-selector-x64.cc
+++ b/src/compiler/x64/instruction-selector-x64.cc
@@ -241,7 +241,7 @@ static void VisitBinop(InstructionSelector* selector,
Node* node,
// TODO(turbofan): match complex addressing modes.
if (g.CanBeImmediate(right)) {
- inputs[input_count++] = g.Use(left);
+ inputs[input_count++] = g.UseRegister(left);
inputs[input_count++] = g.UseImmediate(right);
} else {
if (node->op()->HasProperty(Operator::kCommutative) &&
@@ -305,7 +305,7 @@ void InstructionSelector::VisitWord32Xor(Node* node) {
X64OperandGenerator g(this);
Uint32BinopMatcher m(node);
if (m.right().Is(-1)) {
- Emit(kX64Not32, g.DefineSameAsFirst(node), g.Use(m.left().node()));
+ Emit(kX64Not32, g.DefineSameAsFirst(node),
g.UseRegister(m.left().node()));
} else {
VisitBinop(this, node, kX64Xor32);
}
@@ -316,7 +316,7 @@ void InstructionSelector::VisitWord64Xor(Node* node) {
X64OperandGenerator g(this);
Uint64BinopMatcher m(node);
if (m.right().Is(-1)) {
- Emit(kX64Not, g.DefineSameAsFirst(node), g.Use(m.left().node()));
+ Emit(kX64Not, g.DefineSameAsFirst(node),
g.UseRegister(m.left().node()));
} else {
VisitBinop(this, node, kX64Xor);
}
@@ -332,7 +332,7 @@ static void VisitWord32Shift(InstructionSelector*
selector, Node* node,
Node* right = node->InputAt(1);
if (g.CanBeImmediate(right)) {
- selector->Emit(opcode, g.DefineSameAsFirst(node), g.Use(left),
+ selector->Emit(opcode, g.DefineSameAsFirst(node), g.UseRegister(left),
g.UseImmediate(right));
} else {
Int32BinopMatcher m(node);
@@ -342,7 +342,7 @@ static void VisitWord32Shift(InstructionSelector*
selector, Node* node,
right = mright.left().node();
}
}
- selector->Emit(opcode, g.DefineSameAsFirst(node), g.Use(left),
+ selector->Emit(opcode, g.DefineSameAsFirst(node), g.UseRegister(left),
g.UseFixed(right, rcx));
}
}
@@ -357,7 +357,7 @@ static void VisitWord64Shift(InstructionSelector*
selector, Node* node,
Node* right = node->InputAt(1);
if (g.CanBeImmediate(right)) {
- selector->Emit(opcode, g.DefineSameAsFirst(node), g.Use(left),
+ selector->Emit(opcode, g.DefineSameAsFirst(node), g.UseRegister(left),
g.UseImmediate(right));
} else {
Int64BinopMatcher m(node);
@@ -367,7 +367,7 @@ static void VisitWord64Shift(InstructionSelector*
selector, Node* node,
right = mright.left().node();
}
}
- selector->Emit(opcode, g.DefineSameAsFirst(node), g.Use(left),
+ selector->Emit(opcode, g.DefineSameAsFirst(node), g.UseRegister(left),
g.UseFixed(right, rcx));
}
}
@@ -472,7 +472,7 @@ void InstructionSelector::VisitInt32Sub(Node* node) {
X64OperandGenerator g(this);
Int32BinopMatcher m(node);
if (m.left().Is(0)) {
- Emit(kX64Neg32, g.DefineSameAsFirst(node), g.Use(m.right().node()));
+ Emit(kX64Neg32, g.DefineSameAsFirst(node),
g.UseRegister(m.right().node()));
} else {
VisitBinop(this, node, kX64Sub32);
}
@@ -483,7 +483,7 @@ void InstructionSelector::VisitInt64Sub(Node* node) {
X64OperandGenerator g(this);
Int64BinopMatcher m(node);
if (m.left().Is(0)) {
- Emit(kX64Neg, g.DefineSameAsFirst(node), g.Use(m.right().node()));
+ Emit(kX64Neg, g.DefineSameAsFirst(node),
g.UseRegister(m.right().node()));
} else {
VisitBinop(this, node, kX64Sub);
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
