https://codereview.chromium.org/646393002/diff/200001/src/compiler/instruction-selector.cc
File src/compiler/instruction-selector.cc (right):
https://codereview.chromium.org/646393002/diff/200001/src/compiler/instruction-selector.cc#newcode386
src/compiler/instruction-selector.cc:386: // TODO(bmeurer): We should
not mutate the schedule.
You can remove this TODO.
https://codereview.chromium.org/646393002/diff/200001/src/compiler/instruction.h
File src/compiler/instruction.h (right):
https://codereview.chromium.org/646393002/diff/200001/src/compiler/instruction.h#newcode923
src/compiler/instruction.h:923: const BlockData&
GetBlockData(BasicBlock* block) const {
Can we avoid adding this wrapper function?
https://codereview.chromium.org/646393002/diff/200001/src/compiler/instruction.h#newcode923
src/compiler/instruction.h:923: const BlockData&
GetBlockData(BasicBlock* block) const {
Can we avoid adding this wrapper function?
https://codereview.chromium.org/646393002/diff/200001/src/compiler/instruction.h#newcode929
src/compiler/instruction.h:929: BlockData& GetBlockData(BasicBlock*
block) {
Can we avoid adding this wrapper function?
https://codereview.chromium.org/646393002/diff/200001/src/compiler/schedule.h
File src/compiler/schedule.h (right):
https://codereview.chromium.org/646393002/diff/200001/src/compiler/schedule.h#newcode53
src/compiler/schedule.h:53: class RpoNumber {
Mark as FINAL.
https://codereview.chromium.org/646393002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
