Reviewers: Benedikt Meurer,
https://codereview.chromium.org/646393002/diff/200001/src/compiler/instruction-selector.cc
File src/compiler/instruction-selector.cc (right):
https://codereview.chromium.org/646393002/diff/200001/src/compiler/instruction-selector.cc#newcode386
src/compiler/instruction-selector.cc:386: // TODO(bmeurer): We should
not mutate the schedule.
On 2014/10/14 03:44:13, Benedikt Meurer wrote:
You can remove this TODO.
Done.
https://codereview.chromium.org/646393002/diff/200001/src/compiler/instruction.h
File src/compiler/instruction.h (right):
https://codereview.chromium.org/646393002/diff/200001/src/compiler/instruction.h#newcode923
src/compiler/instruction.h:923: const BlockData&
GetBlockData(BasicBlock* block) const {
On 2014/10/14 03:44:13, Benedikt Meurer wrote:
Can we avoid adding this wrapper function?
Done.
https://codereview.chromium.org/646393002/diff/200001/src/compiler/instruction.h#newcode929
src/compiler/instruction.h:929: BlockData& GetBlockData(BasicBlock*
block) {
On 2014/10/14 03:44:13, Benedikt Meurer wrote:
Can we avoid adding this wrapper function?
Done.
https://codereview.chromium.org/646393002/diff/200001/src/compiler/schedule.h
File src/compiler/schedule.h (right):
https://codereview.chromium.org/646393002/diff/200001/src/compiler/schedule.h#newcode53
src/compiler/schedule.h:53: class RpoNumber {
On 2014/10/14 03:44:13, Benedikt Meurer wrote:
Mark as FINAL.
Done.
Description:
[turbofan] remove some of the dependency of Instruction on Schedule
[email protected]
BUG=
Please review this at https://codereview.chromium.org/646393002/
Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+217, -156 lines):
M src/compiler/arm/code-generator-arm.cc
M src/compiler/arm64/code-generator-arm64.cc
M src/compiler/code-generator.h
M src/compiler/code-generator.cc
M src/compiler/code-generator-impl.h
M src/compiler/ia32/code-generator-ia32.cc
M src/compiler/instruction.h
M src/compiler/instruction.cc
M src/compiler/instruction-selector.cc
M src/compiler/instruction-selector-impl.h
M src/compiler/mips/code-generator-mips.cc
M src/compiler/register-allocator.cc
M src/compiler/schedule.h
M src/compiler/schedule.cc
M src/compiler/x64/code-generator-x64.cc
M src/zone-containers.h
M test/cctest/compiler/test-instruction.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
