LGTM modulo comments
https://codereview.chromium.org/658523002/diff/1/src/compiler/typer.cc
File src/compiler/typer.cc (right):
https://codereview.chromium.org/658523002/diff/1/src/compiler/typer.cc#newcode915
src/compiler/typer.cc:915: return Bounds(Type::Integral32());
I believe this actually returns a pair, so it currently needs Internal
https://codereview.chromium.org/658523002/diff/1/src/compiler/typer.cc#newcode925
src/compiler/typer.cc:925: return Bounds(Type::Integral32());
Same here.
https://codereview.chromium.org/658523002/diff/1/src/compiler/typer.cc#newcode1044
src/compiler/typer.cc:1044: Type::Number(), Type::UntaggedFloat64(),
zone()));
Signed32
https://codereview.chromium.org/658523002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
