lgtm
https://codereview.chromium.org/659513003/diff/1/src/serialize.cc
File src/serialize.cc (right):
https://codereview.chromium.org/659513003/diff/1/src/serialize.cc#newcode2024
src/serialize.cc:2024: HeapObject* clear =
heap_object->GetHeap()->undefined_value();
Since we rebuild the WeakCell list on every GC, serialization should
work correctly.
https://codereview.chromium.org/659513003/diff/1/src/serialize.cc#newcode2025
src/serialize.cc:2025: Script::cast(heap_object)->set_wrapper(clear);
Should we also isolate->counters()->script_wrappers()->Decrement() ?
https://codereview.chromium.org/659513003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
