LGTM (almost :-} )

https://codereview.chromium.org/653263003/diff/1/src/base/platform/platform-posix.cc
File src/base/platform/platform-posix.cc (right):

https://codereview.chromium.org/653263003/diff/1/src/base/platform/platform-posix.cc#newcode263
src/base/platform/platform-posix.cc:263: return
static_cast<int>(pthread_self());
Hmmm, this is still a bit wacky and will fail some day: pthread_t is an
opaque type, and apart from passing it around and comparing it for
equality (via pthread_equal) there's not much you can do portably.

This needs to be fixed for real at some point, but let's see what breaks
for now... :-/

https://codereview.chromium.org/653263003/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to