Revision: 24630
Author: [email protected]
Date: Wed Oct 15 12:15:38 2014 UTC
Log: [turbofan] more verification of rpo
[email protected]
BUG=
Review URL: https://codereview.chromium.org/603533002
https://code.google.com/p/v8/source/detail?r=24630
Modified:
/branches/bleeding_edge/src/compiler/verifier.cc
/branches/bleeding_edge/test/cctest/compiler/test-run-machops.cc
=======================================
--- /branches/bleeding_edge/src/compiler/verifier.cc Wed Oct 15 11:58:30
2014 UTC
+++ /branches/bleeding_edge/src/compiler/verifier.cc Wed Oct 15 12:15:38
2014 UTC
@@ -741,6 +741,17 @@
for (BasicBlockVector::iterator b = rpo_order->begin(); b !=
rpo_order->end();
++b) {
CHECK_EQ((*b), schedule->GetBlockById((*b)->id()));
+ // All predecessors and successors should be in rpo and in this
schedule.
+ for (BasicBlock::Predecessors::iterator j = (*b)->predecessors_begin();
+ j != (*b)->predecessors_end(); ++j) {
+ CHECK_GE((*j)->rpo_number(), 0);
+ CHECK_EQ((*j), schedule->GetBlockById((*j)->id()));
+ }
+ for (BasicBlock::Successors::iterator j = (*b)->successors_begin();
+ j != (*b)->successors_end(); ++j) {
+ CHECK_GE((*j)->rpo_number(), 0);
+ CHECK_EQ((*j), schedule->GetBlockById((*j)->id()));
+ }
}
// Verify RPO numbers of blocks.
=======================================
--- /branches/bleeding_edge/test/cctest/compiler/test-run-machops.cc Tue
Oct 14 11:57:06 2014 UTC
+++ /branches/bleeding_edge/test/cctest/compiler/test-run-machops.cc Wed
Oct 15 12:15:38 2014 UTC
@@ -142,21 +142,6 @@
TEST(RunRedundantBranch2) {
RawMachineAssemblerTester<int32_t> m;
- int constant = 955777;
-
- MLabel blocka, blockb;
- m.Branch(m.Int32Constant(0), &blocka, &blocka);
- m.Bind(&blockb);
- m.Goto(&blocka);
- m.Bind(&blocka);
- m.Return(m.Int32Constant(constant));
-
- CHECK_EQ(constant, m.Call());
-}
-
-
-TEST(RunRedundantBranch3) {
- RawMachineAssemblerTester<int32_t> m;
int constant = 966777;
MLabel blocka, blockb, blockc;
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
