https://codereview.chromium.org/653093002/diff/1/src/compiler/js-operator.h
File src/compiler/js-operator.h (right):
https://codereview.chromium.org/653093002/diff/1/src/compiler/js-operator.h#newcode12
src/compiler/js-operator.h:12: #define SHARED_SIMPLE_BINOP_LIST(V)
\
Please do not expose this just for the sake of a test. It's okay to
repeat the list in the test.
https://codereview.chromium.org/653093002/diff/1/test/cctest/test-types.h
File test/cctest/test-types.h (right):
https://codereview.chromium.org/653093002/diff/1/test/cctest/test-types.h#newcode28
test/cctest/test-types.h:28: #ifndef V8_TEST_CCTEST_TEST_TYPES_H_
Please name this file differently, so that it is not confused with the
.cc file of the same name.
https://codereview.chromium.org/653093002/diff/1/test/cctest/test-types.h#newcode38
test/cctest/test-types.h:38: class Types {
Did anything change in here, other than moving it?
https://codereview.chromium.org/653093002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
