Reviewers: jarin,
Description:
Fix verification of Int64Constant
[email protected]
BUG=
Please review this at https://codereview.chromium.org/660533002/
Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+7, -1 lines):
M src/compiler/verifier.cc
Index: src/compiler/verifier.cc
diff --git a/src/compiler/verifier.cc b/src/compiler/verifier.cc
index
8f0b5a2d2e094b6aac4bad147820534c24c9181c..04005009557fd73e9c144a103be9ddfad13da943
100644
--- a/src/compiler/verifier.cc
+++ b/src/compiler/verifier.cc
@@ -224,7 +224,13 @@ GenericGraphVisit::Control
Verifier::Visitor::Pre(Node* node) {
// Type is a 32 bit integer, signed or unsigned.
CHECK(bounds(node).upper->Is(Type::Integral32()));
break;
- case IrOpcode::kInt64Constant: // Close enough...
+ case IrOpcode::kInt64Constant:
+ // Constants have no inputs.
+ CHECK_EQ(0, input_count);
+ // Type is internal.
+ // TODO(rossberg): Introduce proper Int64 type.
+ CHECK(bounds(node).upper->Is(Type::Internal()));
+ break;
case IrOpcode::kFloat32Constant:
case IrOpcode::kFloat64Constant:
case IrOpcode::kNumberConstant:
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
