Reviewers: Yang,
Message:
Committed patchset #1 (id:1) manually as 24643 (tree was closed).
Description:
Fix compilation after r24639
[email protected]
Committed: https://code.google.com/p/v8/source/detail?r=24643
Please review this at https://codereview.chromium.org/653353003/
Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+3, -2 lines):
M src/serialize.h
M test/cctest/test-serialize.cc
Index: src/serialize.h
diff --git a/src/serialize.h b/src/serialize.h
index
6e1f6512350b24dc56e39b1b25d38ce5b8095652..482bc34e5c03c47fd6bf30f7d0fe097ca9ba2cd8
100644
--- a/src/serialize.h
+++ b/src/serialize.h
@@ -263,7 +263,8 @@ class Deserializer: public SerializerDeserializer {
void AddReservation(int space, uint32_t chunk) {
DCHECK(space >= 0);
DCHECK(space < kNumberOfSpaces);
- DCHECK(space == LO_SPACE || chunk < Page::kMaxRegularHeapObjectSize);
+ DCHECK(space == LO_SPACE ||
+ chunk < static_cast<uint32_t>(Page::kMaxRegularHeapObjectSize));
reservations_[space].Add({chunk, NULL, NULL});
}
Index: test/cctest/test-serialize.cc
diff --git a/test/cctest/test-serialize.cc b/test/cctest/test-serialize.cc
index
15c587b22595a1f2dc10eaba32a4aeb4d437a265..48debe0be4e4f5262a03e0b14faf564f1f40cf9a
100644
--- a/test/cctest/test-serialize.cc
+++ b/test/cctest/test-serialize.cc
@@ -933,7 +933,7 @@ TEST(SerializeToplevelThreeBigStrings) {
isolate->factory()->NewFunctionFromSharedFunctionInfo(
copy, isolate->native_context());
- Execution::Call(isolate, copy_fun, global, 0, NULL);
+ USE(Execution::Call(isolate, copy_fun, global, 0, NULL));
CHECK_EQ(600000 + 700000, CompileRun("(a + b).length")->Int32Value());
CHECK_EQ(500000 + 600000, CompileRun("(b + c).length")->Int32Value());
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
