On 2014/10/16 at 08:35:27, chunyang.dai wrote:
hello, Jochen.
Thank you for your comments.
Yes, This CL will lose some jit code create event if snapshot is switched
off.
According to your comments and my understanding, there are two other
options
for vtune intialization:
1, To invoke InitializeVtuneForV8(v8::Isolate::CreateParams& params)
API in
constructor of IsolateHolder.
( in gin/isolate_holder.cc, line 53 ).
This will introduces more code changes in gin/DEP and gin/gin.gyp so
that vtune code can be linked
during compilation.
2, gin::Debug::SetJitCodeEventhandler(v8::JitCodeEventHandler
event_handler) is invoked to set vtune
jit event handler and Vtune provides another API to provide the
vTune::internal::VTUNEJITInterface::event_handler as parameter of
gin::Debug::SetJitCodeEventhandler
function.
Which one is the best and acceptable option?
I'd prefer (2)
https://codereview.chromium.org/655183002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
