[v8-dev] [v8] r24706 committed - Don't expose Array.prototype.values as it breaks webcompat...

Fri, 17 Oct 2014 13:12:39 -0700 

Revision: 24706
Author:   [email protected]
Date:     Fri Oct 17 20:11:47 2014 UTC
Log:      Don't expose Array.prototype.values as it breaks webcompat

Some versions of Outlook Web Access test for the existence of a 'values'
property on Array instances, so adding the 'values' iterator to the prototype 
(even with @@unscopeables) causes breakage.
This matches Gecko: they ship Array.prototype.{keys,entries} but not 'values'. 

BUG=409858
LOG=Y
[email protected], [email protected]

Review URL: https://codereview.chromium.org/647703003
https://code.google.com/p/v8/source/detail?r=24706

Modified:
 /branches/bleeding_edge/src/array-iterator.js
 /branches/bleeding_edge/src/array.js
 /branches/bleeding_edge/test/mjsunit/es6/arguments-iterator.js
 /branches/bleeding_edge/test/mjsunit/es6/array-iterator.js
 /branches/bleeding_edge/test/mjsunit/es6/typed-array-iterator.js

=======================================
--- /branches/bleeding_edge/src/array-iterator.js Wed Aug 20 19:21:56 2014 UTC +++ /branches/bleeding_edge/src/array-iterator.js Fri Oct 17 20:11:47 2014 UTC 
@@ -120,8 +120,8 @@
   %CheckIsBootstrapping();

   InstallFunctions($Array.prototype, DONT_ENUM, $Array(
+    // No 'values' since it breaks webcompat: http://crbug.com/409858
     'entries', ArrayEntries,
-    'values', ArrayValues,
     'keys', ArrayKeys
   ));

=======================================
--- /branches/bleeding_edge/src/array.js        Wed Oct 15 23:53:02 2014 UTC
+++ /branches/bleeding_edge/src/array.js        Fri Oct 17 20:11:47 2014 UTC
@@ -1499,7 +1499,6 @@
     find: true,
     findIndex: true,
     keys: true,
-    values: true,
   };
   %AddNamedProperty($Array.prototype, symbolUnscopables, unscopables,
       DONT_ENUM | READ_ONLY);
=======================================
--- /branches/bleeding_edge/test/mjsunit/es6/arguments-iterator.js Mon Aug 25 09:12:22 2014 UTC +++ /branches/bleeding_edge/test/mjsunit/es6/arguments-iterator.js Fri Oct 17 20:11:47 2014 UTC 
@@ -16,8 +16,8 @@
   assertTrue(descriptor.writable);
   assertFalse(descriptor.enumerable);
   assertTrue(descriptor.configurable);
-  assertEquals(descriptor.value, [].values);
-  assertEquals(arguments[Symbol.iterator], [].values);
+  assertEquals(descriptor.value, [][Symbol.iterator]);
+  assertEquals(arguments[Symbol.iterator], [][Symbol.iterator]);
 }
 TestDirectArgumentsIteratorProperty();

@@ -26,7 +26,7 @@
   var o = arguments;
   assertTrue(o.hasOwnProperty(Symbol.iterator));
   assertFalse(o.propertyIsEnumerable(Symbol.iterator));
-  assertEquals(o[Symbol.iterator], [].values);
+  assertEquals(o[Symbol.iterator], [][Symbol.iterator]);
 }
 TestIndirectArgumentsIteratorProperty();

@@ -204,27 +204,27 @@
   "use strict";

   var o = {__proto__:arguments};
-  assertSame([].values, o[Symbol.iterator]);
+  assertSame([][Symbol.iterator], o[Symbol.iterator]);
   // Make o dict-mode.
   %OptimizeObjectForAddingMultipleProperties(o, 0);
   assertFalse(o.hasOwnProperty(Symbol.iterator));
-  assertSame([].values, o[Symbol.iterator]);
+  assertSame([][Symbol.iterator], o[Symbol.iterator]);
   o[Symbol.iterator] = 10;
   assertTrue(o.hasOwnProperty(Symbol.iterator));
   assertEquals(10, o[Symbol.iterator]);
-  assertSame([].values, arguments[Symbol.iterator]);
+  assertSame([][Symbol.iterator], arguments[Symbol.iterator]);

   // Frozen o.
   o = Object.freeze({__proto__:arguments});
-  assertSame([].values, o[Symbol.iterator]);
+  assertSame([][Symbol.iterator], o[Symbol.iterator]);
   assertFalse(o.hasOwnProperty(Symbol.iterator));
-  assertSame([].values, o[Symbol.iterator]);
+  assertSame([][Symbol.iterator], o[Symbol.iterator]);
   // This should throw, but currently it doesn't, because
   // ExecutableAccessorInfo callbacks don't see the current strict mode.
   // See note in accessors.cc:SetPropertyOnInstanceIfInherited.
   o[Symbol.iterator] = 10;
   assertFalse(o.hasOwnProperty(Symbol.iterator));
-  assertEquals([].values, o[Symbol.iterator]);
-  assertSame([].values, arguments[Symbol.iterator]);
+  assertEquals([][Symbol.iterator], o[Symbol.iterator]);
+  assertSame([][Symbol.iterator], arguments[Symbol.iterator]);
 }
 TestArgumentsAsProto();
=======================================
--- /branches/bleeding_edge/test/mjsunit/es6/array-iterator.js Thu Aug 21 09:04:24 2014 UTC +++ /branches/bleeding_edge/test/mjsunit/es6/array-iterator.js Fri Oct 17 20:11:47 2014 UTC 
@@ -45,11 +45,8 @@

 function TestArrayPrototype() {
   assertHasOwnProperty(Array.prototype, 'entries', DONT_ENUM);
-  assertHasOwnProperty(Array.prototype, 'values', DONT_ENUM);
   assertHasOwnProperty(Array.prototype, 'keys', DONT_ENUM);
   assertHasOwnProperty(Array.prototype, Symbol.iterator, DONT_ENUM);
-
-  assertEquals(Array.prototype.values, Array.prototype[Symbol.iterator]);
 }
 TestArrayPrototype();

@@ -61,7 +58,7 @@

 function TestValues() {
   var array = ['a', 'b', 'c'];
-  var iterator = array.values();
+  var iterator = array[Symbol.iterator]();
   assertIteratorResult('a', false, iterator.next());
   assertIteratorResult('b', false, iterator.next());
   assertIteratorResult('c', false, iterator.next());
@@ -75,7 +72,7 @@

 function TestValuesMutate() {
   var array = ['a', 'b', 'c'];
-  var iterator = array.values();
+  var iterator = array[Symbol.iterator]();
   assertIteratorResult('a', false, iterator.next());
   assertIteratorResult('b', false, iterator.next());
   assertIteratorResult('c', false, iterator.next());
@@ -142,17 +139,17 @@

 function TestArrayIteratorPrototype() {
   var array = [];
-  var iterator = array.values();
+  var iterator = array.keys();

   var ArrayIteratorPrototype = iterator.__proto__;

-  assertEquals(ArrayIteratorPrototype, array.values().__proto__);
+  assertEquals(ArrayIteratorPrototype, array[Symbol.iterator]().__proto__);
   assertEquals(ArrayIteratorPrototype, array.keys().__proto__);
   assertEquals(ArrayIteratorPrototype, array.entries().__proto__);

   assertEquals(Object.prototype, ArrayIteratorPrototype.__proto__);

-  assertEquals('Array Iterator', %_ClassOf(array.values()));
+  assertEquals('Array Iterator', %_ClassOf(array[Symbol.iterator]()));
   assertEquals('Array Iterator', %_ClassOf(array.keys()));
   assertEquals('Array Iterator', %_ClassOf(array.entries()));

@@ -169,7 +166,7 @@
   var buffer = [];
   var array = [0, 'a', true, false, null, /* hole */, undefined, NaN];
   var i = 0;
-  for (var value of array.values()) {
+  for (var value of array[Symbol.iterator]()) {
     buffer[i++] = value;
   }

@@ -239,7 +236,7 @@

 function TestNonOwnSlots() {
   var array = [0];
-  var iterator = array.values();
+  var iterator = array[Symbol.iterator]();
   var object = {__proto__: iterator};

   assertThrows(function() {
=======================================
--- /branches/bleeding_edge/test/mjsunit/es6/typed-array-iterator.js Thu Aug 7 16:42:14 2014 UTC +++ /branches/bleeding_edge/test/mjsunit/es6/typed-array-iterator.js Fri Oct 17 20:11:47 2014 UTC 
@@ -21,9 +21,9 @@
   assertFalse(constructor.prototype.propertyIsEnumerable(Symbol.iterator));

   assertEquals(Array.prototype.entries, constructor.prototype.entries);
-  assertEquals(Array.prototype.values, constructor.prototype.values);
+ assertEquals(Array.prototype[Symbol.iterator], constructor.prototype.values); 
   assertEquals(Array.prototype.keys, constructor.prototype.keys);
- assertEquals(Array.prototype.values, constructor.prototype[Symbol.iterator]); + assertEquals(Array.prototype[Symbol.iterator], constructor.prototype[Symbol.iterator]); 
 }
 constructors.forEach(TestTypedArrayPrototype);

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group. 
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to