Reviewers: Weiliang, bnoordhuis,
Message:
WL
PTAL.
thanks
Description:
X87: Make disassembler string tables read-only.
port r24672.
original commit message:
Move them from .data to .rodata.
BUG=
Please review this at https://codereview.chromium.org/654263006/
Base URL: https://chromium.googlesource.com/external/v8.git@bleeding_edge
Affected files (+3, -3 lines):
M src/x87/disasm-x87.cc
Index: src/x87/disasm-x87.cc
diff --git a/src/x87/disasm-x87.cc b/src/x87/disasm-x87.cc
index
908e8b04399271528f1e8652d439a183b76c0a17..8c77d7718da82c4722a17d3b0c80acc9586478cd
100644
--- a/src/x87/disasm-x87.cc
+++ b/src/x87/disasm-x87.cc
@@ -1698,17 +1698,17 @@ int
DisassemblerX87::InstructionDecode(v8::internal::Vector<char> out_buffer,
//------------------------------------------------------------------------------
-static const char* cpu_regs[8] = {
+static const char* const cpu_regs[8] = {
"eax", "ecx", "edx", "ebx", "esp", "ebp", "esi", "edi"
};
-static const char* byte_cpu_regs[8] = {
+static const char* const byte_cpu_regs[8] = {
"al", "cl", "dl", "bl", "ah", "ch", "dh", "bh"
};
-static const char* xmm_regs[8] = {
+static const char* const xmm_regs[8] = {
"xmm0", "xmm1", "xmm2", "xmm3", "xmm4", "xmm5", "xmm6", "xmm7"
};
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
