Getting very close. Just a few comments, mostly nits.
https://codereview.chromium.org/571173003/diff/20001/src/ppc/code-stubs-ppc.cc
File src/ppc/code-stubs-ppc.cc (right):
https://codereview.chromium.org/571173003/diff/20001/src/ppc/code-stubs-ppc.cc#newcode1
src/ppc/code-stubs-ppc.cc:1: // Copyright 2012 the V8 project authors.
All rights reserved.
Here and elsewhere, please change the year to 2014
https://codereview.chromium.org/571173003/diff/20001/src/ppc/code-stubs-ppc.cc#newcode159
src/ppc/code-stubs-ppc.cc:159: #if V8_TARGET_ARCH_PPC64
Here and elsewhere where possible, can you turn this into a
if (V8_TARGET_ARCH_PPC) instead? This makes more code compile on both
platforms and reduces the number of #ifdefs.
https://codereview.chromium.org/571173003/diff/20001/src/ppc/code-stubs-ppc.cc#newcode301
src/ppc/code-stubs-ppc.cc:301: #endif // roohack
Do you still want the block above in the code?
https://codereview.chromium.org/571173003/diff/20001/src/ppc/code-stubs-ppc.cc#newcode984
src/ppc/code-stubs-ppc.cc:984: //
WriteInt32ToHeapNumberStub::GenerateFixedRegStubsAheadOfTime(isolate);
Really delete this line?
https://codereview.chromium.org/571173003/diff/20001/src/ppc/code-stubs-ppc.cc#newcode4385
src/ppc/code-stubs-ppc.cc:4385: #if ABI_USES_FUNCTION_DESCRIPTORS
Is it possible to use just an "if" and not "#if"?
https://codereview.chromium.org/571173003/diff/20001/src/ppc/codegen-ppc.cc
File src/ppc/codegen-ppc.cc (right):
https://codereview.chromium.org/571173003/diff/20001/src/ppc/codegen-ppc.cc#newcode377
src/ppc/codegen-ppc.cc:377: // heap_number: new heap number
Indentation?
https://codereview.chromium.org/571173003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
