Reviewers: dcarney,
Description:
Remove deprecated Ascii-related identifiers from include/v8.h
[email protected]
Please review this at https://codereview.chromium.org/665883002/
Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+0, -12 lines):
M include/v8.h
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index
a191c07d24f3d6677faa82178791265c6cd78d0a..6335879d63a4ebd43e65e912074abed914331423
100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -1773,7 +1773,6 @@ class V8_EXPORT String : public Name {
enum Encoding {
UNKNOWN_ENCODING = 0x1,
TWO_BYTE_ENCODING = 0x0,
- ASCII_ENCODING = 0x4, // TODO(yangguo): deprecate this.
ONE_BYTE_ENCODING = 0x4
};
/**
@@ -1829,7 +1828,6 @@ class V8_EXPORT String : public Name {
NO_OPTIONS = 0,
HINT_MANY_WRITES_EXPECTED = 1,
NO_NULL_TERMINATION = 2,
- PRESERVE_ASCII_NULL = 4, // TODO(yangguo): deprecate this.
PRESERVE_ONE_BYTE_NULL = 4,
// Used by WriteUtf8 to replace orphan surrogate code units with the
// unicode replacement character. Needs to be set to guarantee valid
UTF-8
@@ -1868,9 +1866,6 @@ class V8_EXPORT String : public Name {
*/
bool IsExternalOneByte() const;
- // TODO(yangguo): deprecate this.
- bool IsExternalAscii() const { return IsExternalOneByte(); }
-
class V8_EXPORT ExternalStringResourceBase { // NOLINT
public:
virtual ~ExternalStringResourceBase() {}
@@ -1949,8 +1944,6 @@ class V8_EXPORT String : public Name {
ExternalOneByteStringResource() {}
};
- typedef ExternalOneByteStringResource ExternalAsciiStringResource;
-
/**
* If the string is an external string, return the
ExternalStringResourceBase
* regardless of the encoding, otherwise return NULL. The encoding of
the
@@ -1971,11 +1964,6 @@ class V8_EXPORT String : public Name {
*/
const ExternalOneByteStringResource* GetExternalOneByteStringResource()
const;
- // TODO(yangguo): deprecate this.
- const ExternalAsciiStringResource* GetExternalAsciiStringResource()
const {
- return GetExternalOneByteStringResource();
- }
-
V8_INLINE static String* Cast(v8::Value* obj);
enum NewStringType {
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
