Revision: 24730
Author: [email protected]
Date: Mon Oct 20 11:27:39 2014 UTC
Log: platform: fix build on SmartOS
With -std=g++0x, `signbit` is no longer a define, and is an actual
function declared in C++-specific headers. Thus checking it's presence
with ifdef will no longer work.
Considering that g++0x implies newer compiler, there should not be the
case where it won't be present anymore.
BUG=
[email protected], danno
Review URL: https://codereview.chromium.org/642203003
Patch from Fedor Indutny <[email protected]>.
https://code.google.com/p/v8/source/detail?r=24730
Modified:
/branches/bleeding_edge/src/base/platform/platform-solaris.cc
/branches/bleeding_edge/src/base/platform/platform.h
=======================================
--- /branches/bleeding_edge/src/base/platform/platform-solaris.cc Mon Sep
8 04:44:22 2014 UTC
+++ /branches/bleeding_edge/src/base/platform/platform-solaris.cc Mon Oct
20 11:27:39 2014 UTC
@@ -31,26 +31,6 @@
#include "src/base/platform/platform.h"
-// It seems there is a bug in some Solaris distributions (experienced in
-// SunOS 5.10 Generic_141445-09) which make it difficult or impossible to
-// access signbit() despite the availability of other C99 math functions.
-#ifndef signbit
-namespace std {
-// Test sign - usually defined in math.h
-int signbit(double x) {
- // We need to take care of the special case of both positive and negative
- // versions of zero.
- if (x == 0) {
- return fpclass(x) & FP_NZERO;
- } else {
- // This won't detect negative NaN but that should be okay since we
don't
- // assume that behavior.
- return x < 0;
- }
-}
-} // namespace std
-#endif // signbit
-
namespace v8 {
namespace base {
=======================================
--- /branches/bleeding_edge/src/base/platform/platform.h Wed Aug 27
08:29:22 2014 UTC
+++ /branches/bleeding_edge/src/base/platform/platform.h Mon Oct 20
11:27:39 2014 UTC
@@ -29,14 +29,6 @@
#include "src/base/platform/mutex.h"
#include "src/base/platform/semaphore.h"
-#ifdef __sun
-# ifndef signbit
-namespace std {
-int signbit(double x);
-}
-# endif
-#endif
-
#if V8_OS_QNX
#include "src/base/qnx-math.h"
#endif
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
