LGTM with a nit. Node code is good code! :-)
https://codereview.chromium.org/656143004/diff/20001/include/v8config.h
File include/v8config.h (right):
https://codereview.chromium.org/656143004/diff/20001/include/v8config.h#newcode283
include/v8config.h:283: // Visual Studio 2010 and earlier spell "final"
as "sealed".
The comment above is not useful anymore => nuke it! >:-)
https://codereview.chromium.org/656143004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
