lgtm
Thanks! Looks nicer this way... :)
https://codereview.chromium.org/670433003/diff/1/src/d8.cc
File src/d8.cc (right):
https://codereview.chromium.org/670433003/diff/1/src/d8.cc#newcode180
src/d8.cc:180: ScriptCompiler::CachedData* Shell::CompileCachedData(
nitpick: I suspect this shouldn't be used outside of CompileString, so
I'd just make this a local helper function rather than declare it in
ScriptCompiler. Alternatively, make it private.
https://codereview.chromium.org/670433003/diff/1/src/d8.cc#newcode180
src/d8.cc:180: ScriptCompiler::CachedData* Shell::CompileCachedData(
naming nitpick: CompileForCachedData?
(You're not actually compiling the CachedData; you're compiling for the
benefit of obtaining the cached data.)
https://codereview.chromium.org/670433003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
