[v8-dev] [v8] r24747 committed - Version 3.28.71.17 (merged r24706, r24708)...

Mon, 20 Oct 2014 13:16:58 -0700 

Revision: 24747
Author:   [email protected]
Date:     Mon Oct 20 20:15:35 2014 UTC
Log:      Version 3.28.71.17 (merged r24706, r24708)

Don't expose Array.prototype.values as it breaks webcompat
Fix webkit getOwnPropertyNames test after r24706 removed Array.prototype.values 

BUG=chromium:409858
LOG=N
[email protected]

Review URL: https://codereview.chromium.org/670533003
https://code.google.com/p/v8/source/detail?r=24747

Modified:
 /branches/3.28/src/array-iterator.js
 /branches/3.28/src/array.js
 /branches/3.28/src/version.cc
 /branches/3.28/test/mjsunit/es6/array-iterator.js
 /branches/3.28/test/mjsunit/es6/typed-array-iterator.js
 /branches/3.28/test/webkit/fast/js/Object-getOwnPropertyNames-expected.txt
 /branches/3.28/test/webkit/fast/js/Object-getOwnPropertyNames.js

=======================================
--- /branches/3.28/src/array-iterator.js        Tue Jul 15 00:04:47 2014 UTC
+++ /branches/3.28/src/array-iterator.js        Mon Oct 20 20:15:35 2014 UTC
@@ -120,8 +120,8 @@
   %CheckIsBootstrapping();

   InstallFunctions($Array.prototype, DONT_ENUM, $Array(
+    // No 'values' since it breaks webcompat: http://crbug.com/409858
     'entries', ArrayEntries,
-    'values', ArrayValues,
     'keys', ArrayKeys
   ));

=======================================
--- /branches/3.28/src/array.js Fri Aug  8 15:46:17 2014 UTC
+++ /branches/3.28/src/array.js Mon Oct 20 20:15:35 2014 UTC
@@ -1480,7 +1480,6 @@
     find: true,
     findIndex: true,
     keys: true,
-    values: true,
   };
   %AddNamedProperty($Array.prototype, symbolUnscopables, unscopables,
       DONT_ENUM | READ_ONLY);
=======================================
--- /branches/3.28/src/version.cc       Tue Oct 14 08:52:34 2014 UTC
+++ /branches/3.28/src/version.cc       Mon Oct 20 20:15:35 2014 UTC
@@ -35,7 +35,7 @@
 #define MAJOR_VERSION     3
 #define MINOR_VERSION     28
 #define BUILD_NUMBER      71
-#define PATCH_LEVEL 16
+#define PATCH_LEVEL 17
 // Use 1 for candidates and 0 otherwise.
 // (Boolean macro values are not supported by all preprocessors.)
 #define IS_CANDIDATE_VERSION 0
=======================================
--- /branches/3.28/test/mjsunit/es6/array-iterator.js Fri Aug 8 15:46:17 2014 UTC +++ /branches/3.28/test/mjsunit/es6/array-iterator.js Mon Oct 20 20:15:35 2014 UTC 
@@ -45,11 +45,8 @@

 function TestArrayPrototype() {
   assertHasOwnProperty(Array.prototype, 'entries', DONT_ENUM);
-  assertHasOwnProperty(Array.prototype, 'values', DONT_ENUM);
   assertHasOwnProperty(Array.prototype, 'keys', DONT_ENUM);
   assertHasOwnProperty(Array.prototype, Symbol.iterator, DONT_ENUM);
-
-  assertEquals(Array.prototype.values, Array.prototype[Symbol.iterator]);
 }
 TestArrayPrototype();

@@ -61,7 +58,7 @@

 function TestValues() {
   var array = ['a', 'b', 'c'];
-  var iterator = array.values();
+  var iterator = array[Symbol.iterator]();
   assertIteratorResult('a', false, iterator.next());
   assertIteratorResult('b', false, iterator.next());
   assertIteratorResult('c', false, iterator.next());
@@ -75,7 +72,7 @@

 function TestValuesMutate() {
   var array = ['a', 'b', 'c'];
-  var iterator = array.values();
+  var iterator = array[Symbol.iterator]();
   assertIteratorResult('a', false, iterator.next());
   assertIteratorResult('b', false, iterator.next());
   assertIteratorResult('c', false, iterator.next());
@@ -142,17 +139,17 @@

 function TestArrayIteratorPrototype() {
   var array = [];
-  var iterator = array.values();
+  var iterator = array.keys();

   var ArrayIteratorPrototype = iterator.__proto__;

-  assertEquals(ArrayIteratorPrototype, array.values().__proto__);
+  assertEquals(ArrayIteratorPrototype, array[Symbol.iterator]().__proto__);
   assertEquals(ArrayIteratorPrototype, array.keys().__proto__);
   assertEquals(ArrayIteratorPrototype, array.entries().__proto__);

   assertEquals(Object.prototype, ArrayIteratorPrototype.__proto__);

-  assertEquals('Array Iterator', %_ClassOf(array.values()));
+  assertEquals('Array Iterator', %_ClassOf(array[Symbol.iterator]()));
   assertEquals('Array Iterator', %_ClassOf(array.keys()));
   assertEquals('Array Iterator', %_ClassOf(array.entries()));

@@ -169,7 +166,7 @@
   var buffer = [];
   var array = [0, 'a', true, false, null, /* hole */, undefined, NaN];
   var i = 0;
-  for (var value of array.values()) {
+  for (var value of array[Symbol.iterator]()) {
     buffer[i++] = value;
   }

@@ -242,7 +239,7 @@

 function TestNonOwnSlots() {
   var array = [0];
-  var iterator = array.values();
+  var iterator = array[Symbol.iterator]();
   var object = {__proto__: iterator};

   assertThrows(function() {
=======================================
--- /branches/3.28/test/mjsunit/es6/typed-array-iterator.js Fri Aug 8 15:46:17 2014 UTC +++ /branches/3.28/test/mjsunit/es6/typed-array-iterator.js Mon Oct 20 20:15:35 2014 UTC 
@@ -21,9 +21,9 @@
   assertFalse(constructor.prototype.propertyIsEnumerable(Symbol.iterator));

   assertEquals(Array.prototype.entries, constructor.prototype.entries);
-  assertEquals(Array.prototype.values, constructor.prototype.values);
+ assertEquals(Array.prototype[Symbol.iterator], constructor.prototype.values); 
   assertEquals(Array.prototype.keys, constructor.prototype.keys);
- assertEquals(Array.prototype.values, constructor.prototype[Symbol.iterator]); + assertEquals(Array.prototype[Symbol.iterator], constructor.prototype[Symbol.iterator]); 
 }
 constructors.forEach(TestTypedArrayPrototype);

=======================================
--- /branches/3.28/test/webkit/fast/js/Object-getOwnPropertyNames-expected.txt Fri Aug 8 15:46:17 2014 UTC +++ /branches/3.28/test/webkit/fast/js/Object-getOwnPropertyNames-expected.txt Mon Oct 20 20:15:35 2014 UTC 
@@ -68,7 +68,7 @@
PASS getSortedOwnPropertyNames(Function) is ['arguments', 'caller', 'length', 'name', 'prototype'] PASS getSortedOwnPropertyNames(Function.prototype) is ['apply', 'arguments', 'bind', 'call', 'caller', 'constructor', 'length', 'name', 'toString'] PASS getSortedOwnPropertyNames(Array) is ['arguments', 'caller', 'isArray', 'length', 'name', 'observe', 'prototype', 'unobserve'] -PASS getSortedOwnPropertyNames(Array.prototype) is ['concat', 'constructor', 'entries', 'every', 'filter', 'forEach', 'indexOf', 'join', 'keys', 'lastIndexOf', 'length', 'map', 'pop', 'push', 'reduce', 'reduceRight', 'reverse', 'shift', 'slice', 'some', 'sort', 'splice', 'toLocaleString', 'toString', 'unshift', 'values'] +PASS getSortedOwnPropertyNames(Array.prototype) is ['concat', 'constructor', 'entries', 'every', 'filter', 'forEach', 'indexOf', 'join', 'keys', 'lastIndexOf', 'length', 'map', 'pop', 'push', 'reduce', 'reduceRight', 'reverse', 'shift', 'slice', 'some', 'sort', 'splice', 'toLocaleString', 'toString', 'unshift'] PASS getSortedOwnPropertyNames(String) is ['arguments', 'caller', 'fromCharCode', 'length', 'name', 'prototype'] PASS getSortedOwnPropertyNames(String.prototype) is ['anchor', 'big', 'blink', 'bold', 'charAt', 'charCodeAt', 'concat', 'constructor', 'fixed', 'fontcolor', 'fontsize', 'indexOf', 'italics', 'lastIndexOf', 'length', 'link', 'localeCompare', 'match', 'normalize', 'replace', 'search', 'slice', 'small', 'split', 'strike', 'sub', 'substr', 'substring', 'sup', 'toLocaleLowerCase', 'toLocaleUpperCase', 'toLowerCase', 'toString', 'toUpperCase', 'trim', 'trimLeft', 'trimRight', 'valueOf'] PASS getSortedOwnPropertyNames(Boolean) is ['arguments', 'caller', 'length', 'name', 'prototype'] 
=======================================
--- /branches/3.28/test/webkit/fast/js/Object-getOwnPropertyNames.js Fri Aug 8 15:46:17 2014 UTC +++ /branches/3.28/test/webkit/fast/js/Object-getOwnPropertyNames.js Mon Oct 20 20:15:35 2014 UTC 
@@ -76,7 +76,7 @@
     "Function": "['arguments', 'caller', 'length', 'name', 'prototype']",
     "Function.prototype": "['apply', 'arguments', 'bind', 'call', 'caller', 
'constructor', 'length', 'name', 'toString']",
     "Array": "['arguments', 'caller', 'isArray', 'length', 'name', 'observe', 
'prototype', 'unobserve']",
-    "Array.prototype": "['concat', 'constructor', 'entries', 'every', 'filter', 
'forEach', 'indexOf', 'join', 'keys', 'lastIndexOf', 'length', 'map', 'pop', 'push', 'reduce', 
'reduceRight', 'reverse', 'shift', 'slice', 'some', 'sort', 'splice', 'toLocaleString', 'toString', 
'unshift', 'values']",
+    "Array.prototype": "['concat', 'constructor', 'entries', 'every', 'filter', 
'forEach', 'indexOf', 'join', 'keys', 'lastIndexOf', 'length', 'map', 'pop', 'push', 'reduce', 
'reduceRight', 'reverse', 'shift', 'slice', 'some', 'sort', 'splice', 'toLocaleString', 'toString', 
'unshift']",
     "String": "['arguments', 'caller', 'fromCharCode', 'length', 'name', 
'prototype']",
     "String.prototype": "['anchor', 'big', 'blink', 'bold', 'charAt', 'charCodeAt', 
'concat', 'constructor', 'fixed', 'fontcolor', 'fontsize', 'indexOf', 'italics', 'lastIndexOf', 
'length', 'link', 'localeCompare', 'match', 'normalize', 'replace', 'search', 'slice', 'small', 
'split', 'strike', 'sub', 'substr', 'substring', 'sup', 'toLocaleLowerCase', 'toLocaleUpperCase', 
'toLowerCase', 'toString', 'toUpperCase', 'trim', 'trimLeft', 'trimRight', 'valueOf']",
     "Boolean": "['arguments', 'caller', 'length', 'name', 'prototype']",

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group. 
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to