On 2014/10/21 01:09:37, caitp wrote:
https://codereview.chromium.org/649203004/diff/1/src/messages.js
File src/messages.js (right):
https://codereview.chromium.org/649203004/diff/1/src/messages.js#newcode229
src/messages.js:229: if (IS_OBJECT(obj)) {
So, this will cause arrays to always be reported as `#<Array>` rather than
`[object Array]` --- I'm not sure if that's the right behaviour or not ---
probably doesn't matter a whole lot, but it might be reported as a
regression.
Same thing for similar cases where the `toString` function is overridden
somewhere in the prototype chain.
Maybe a better solution is to change the toStringTag CL to make this
check for
both default ObjectToString functions?
Good point. Let's do that. Closing this issue.
https://codereview.chromium.org/649203004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
