[v8-dev] Re: Remove v8stdint.h, it doesn't serve a purpose anymore. (issue 670673002 by [email protected])

Tue, 21 Oct 2014 01:26:17 -0700 

Reviewers: Benedikt Meurer,

Message:
Committed patchset #3 (id:40001) manually as 24755 (presubmit successful).

Description:
Remove v8stdint.h, it doesn't serve a purpose anymore.

Basically a follow-up to https://codereview.chromium.org/667573005/.

LOG=y
[email protected]

Committed: https://code.google.com/p/v8/source/detail?r=24755

Please review this at https://codereview.chromium.org/670673002/

Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files (+33, -39 lines):
  M include/v8.h
  D include/v8stdint.h
  M src/assert-scope.h
  M src/base/atomicops.h
  M src/base/bits.h
  M src/base/functional.h
  M src/base/logging.h
  M src/base/macros.h
  M src/base/once.h
  M src/base/sys-info.h
  M src/bignum-dtoa.cc
  M src/cached-powers.cc
  M src/diy-fp.cc
  M src/dtoa.cc
  M src/fast-dtoa.cc
  M src/fixed-dtoa.cc
  M src/globals.h
  M src/preparse-data.cc
  M src/preparser.cc
  M src/scanner.cc
  M src/token.cc
  M test/cctest/test-platform.cc
  M test/unittests/base/division-by-constant-unittest.cc
  M test/unittests/base/flags-unittest.cc
  M testing/gtest-support.h


Index: include/v8stdint.h
diff --git a/include/v8stdint.h b/include/v8stdint.h
deleted file mode 100644
index ce25481b5c4cbc3b5eef34eb0e97aa4abc7f8b55..0000000000000000000000000000000000000000 
--- a/include/v8stdint.h
+++ /dev/null
@@ -1,16 +0,0 @@
-// Copyright 2012 the V8 project authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-// Load definitions of standard types.
-
-#ifndef V8STDINT_H_
-#define V8STDINT_H_
-
-#include <stddef.h>
-#include <stdint.h>
-#include <stdio.h>
-
-#include "v8config.h"
-
-#endif  // V8STDINT_H_
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index 6335879d63a4ebd43e65e912074abed914331423..750adf83d6bce7f8fcd795325cb710890d7d11ed 100644 
--- a/include/v8.h
+++ b/include/v8.h
@@ -15,7 +15,11 @@
 #ifndef V8_H_
 #define V8_H_

-#include "v8stdint.h"
+#include <stddef.h>
+#include <stdint.h>
+#include <stdio.h>
+
+#include "v8config.h"

 // We reserve the V8_* prefix for macros defined in V8 public API and
 // assume there are no name conflicts with the embedder's code.
Index: src/assert-scope.h
diff --git a/src/assert-scope.h b/src/assert-scope.h
index 41baa65563fb5ac801ee02a720b178bf15cce04f..0f1e056fbac711ecc82e937a858e021f1a91574c 100644 
--- a/src/assert-scope.h
+++ b/src/assert-scope.h
@@ -5,7 +5,7 @@
 #ifndef V8_ASSERT_SCOPE_H_
 #define V8_ASSERT_SCOPE_H_

-#include "include/v8stdint.h"
+#include <stdint.h>
 #include "src/base/macros.h"

 namespace v8 {
Index: src/base/atomicops.h
diff --git a/src/base/atomicops.h b/src/base/atomicops.h
index 2f4b46461b366b151663abd8aafbea8183fc8f22..675e43fad0030086d4fa8a98d51fb3e628478869 100644 
--- a/src/base/atomicops.h
+++ b/src/base/atomicops.h
@@ -25,7 +25,7 @@
 #ifndef V8_BASE_ATOMICOPS_H_
 #define V8_BASE_ATOMICOPS_H_

-#include "include/v8stdint.h"
+#include <stdint.h>
 #include "src/base/build_config.h"

 #if defined(_WIN32) && defined(V8_HOST_ARCH_64_BIT)
Index: src/base/bits.h
diff --git a/src/base/bits.h b/src/base/bits.h
index 5e0e248a02ba082535543f6cb8ad1df5ba65f161..da4d1f20ae959ad70dc145489246d7da2d41e20b 100644 
--- a/src/base/bits.h
+++ b/src/base/bits.h
@@ -5,7 +5,7 @@
 #ifndef V8_BASE_BITS_H_
 #define V8_BASE_BITS_H_

-#include "include/v8stdint.h"
+#include <stdint.h>
 #include "src/base/macros.h"
 #if V8_CC_MSVC
 #include <intrin.h>
Index: src/base/functional.h
diff --git a/src/base/functional.h b/src/base/functional.h
index 996628527607f74a84fb0aeca847a13c97bd7d54..ff0d8075b943079de99555dc9ec733ca5ba0337b 100644 
--- a/src/base/functional.h
+++ b/src/base/functional.h
@@ -5,12 +5,14 @@
 #ifndef V8_BASE_FUNCTIONAL_H_
 #define V8_BASE_FUNCTIONAL_H_

+#include <stddef.h>
+#include <stdint.h>
+
 #include <cstddef>
 #include <cstring>
 #include <functional>
 #include <utility>

-#include "include/v8stdint.h"
 #include "src/base/macros.h"

 namespace v8 {
Index: src/base/logging.h
diff --git a/src/base/logging.h b/src/base/logging.h
index 8e24bb0864ee5ee1d1c4409e5f666145711a4e61..83c1bb60136c1ec9d626c0230db452f3dbb2bf96 100644 
--- a/src/base/logging.h
+++ b/src/base/logging.h
@@ -5,9 +5,9 @@
 #ifndef V8_BASE_LOGGING_H_
 #define V8_BASE_LOGGING_H_

+#include <stdint.h>
 #include <string.h>

-#include "include/v8stdint.h"
 #include "src/base/build_config.h"
extern "C" void V8_Fatal(const char* file, int line, const char* format, ...); 
Index: src/base/macros.h
diff --git a/src/base/macros.h b/src/base/macros.h
index 1832a44cd365f2f67a62cfbc4fd7270d041c565e..79cf04ccf2b2637a0c70234ac49849b27e22f20b 100644 
--- a/src/base/macros.h
+++ b/src/base/macros.h
@@ -5,9 +5,11 @@
 #ifndef V8_BASE_MACROS_H_
 #define V8_BASE_MACROS_H_

+#include <stddef.h>
+#include <stdint.h>
+
 #include <cstring>

-#include "include/v8stdint.h"
 #include "src/base/build_config.h"
 #include "src/base/compiler-specific.h"
 #include "src/base/logging.h"
Index: src/base/once.h
diff --git a/src/base/once.h b/src/base/once.h
index a8e8437afaad392d2bdb4247e69d18e336e59695..6bf741d38a998b1aa9ce43ccd7134c30014c0922 100644 
--- a/src/base/once.h
+++ b/src/base/once.h
@@ -52,6 +52,8 @@
 #ifndef V8_BASE_ONCE_H_
 #define V8_BASE_ONCE_H_

+#include <stddef.h>
+
 #include "src/base/atomicops.h"

 namespace v8 {
Index: src/base/sys-info.h
diff --git a/src/base/sys-info.h b/src/base/sys-info.h
index d1658fc09dcc894e3f8db2177fe6e6a276a41d56..377deb071676143bdcef32e32c802a97ffb60404 100644 
--- a/src/base/sys-info.h
+++ b/src/base/sys-info.h
@@ -5,7 +5,7 @@
 #ifndef V8_BASE_SYS_INFO_H_
 #define V8_BASE_SYS_INFO_H_

-#include "include/v8stdint.h"
+#include <stdint.h>
 #include "src/base/compiler-specific.h"

 namespace v8 {
Index: src/bignum-dtoa.cc
diff --git a/src/bignum-dtoa.cc b/src/bignum-dtoa.cc
index 53bf418f936407eeac0a2e282e96ba2e399c3a32..f9a0c95ef525e82fab51827cd323940b0bae6b95 100644 
--- a/src/bignum-dtoa.cc
+++ b/src/bignum-dtoa.cc
@@ -4,7 +4,6 @@

 #include <cmath>

-#include "include/v8stdint.h"
 #include "src/base/logging.h"
 #include "src/utils.h"

Index: src/cached-powers.cc
diff --git a/src/cached-powers.cc b/src/cached-powers.cc
index dd9e3b4d3f3f7683f50e6ed0a5912d97deec1fe9..ccf8882e76a261eaa5e13b0fe87555f0ed361900 100644 
--- a/src/cached-powers.cc
+++ b/src/cached-powers.cc
@@ -4,9 +4,9 @@

 #include <limits.h>
 #include <stdarg.h>
+#include <stdint.h>
 #include <cmath>

-#include "include/v8stdint.h"
 #include "src/base/logging.h"
 #include "src/cached-powers.h"
 #include "src/globals.h"
Index: src/diy-fp.cc
diff --git a/src/diy-fp.cc b/src/diy-fp.cc
index cdad2a8ae226b662a9121b092adc185e0ff66781..b705df0e679dc6e2ccb6048188c7052ef0de00e2 100644 
--- a/src/diy-fp.cc
+++ b/src/diy-fp.cc
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-#include "include/v8stdint.h"
+#include <stdint.h>
 #include "src/base/logging.h"
 #include "src/diy-fp.h"
 #include "src/globals.h"
Index: src/dtoa.cc
diff --git a/src/dtoa.cc b/src/dtoa.cc
index f39b0b070d3035b63eacb4f9940d1d8a4983c0e1..fc02aca29970280d4467fadf3f5714f2e213db6e 100644 
--- a/src/dtoa.cc
+++ b/src/dtoa.cc
@@ -4,7 +4,6 @@

 #include <cmath>

-#include "include/v8stdint.h"
 #include "src/base/logging.h"
 #include "src/utils.h"

Index: src/fast-dtoa.cc
diff --git a/src/fast-dtoa.cc b/src/fast-dtoa.cc
index 13b04634de7685c749850dc676a196d4c6f4383e..d6edddce1df6d9a516c6dee69bc3313b0283072f 100644 
--- a/src/fast-dtoa.cc
+++ b/src/fast-dtoa.cc
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-#include "include/v8stdint.h"
+#include <stdint.h>
 #include "src/base/logging.h"
 #include "src/utils.h"

Index: src/fixed-dtoa.cc
diff --git a/src/fixed-dtoa.cc b/src/fixed-dtoa.cc
index 56fe9abafa1a94e35d8c8efce2e4a485ea0913e5..7856b13108bf8ae954894f5dcd7dca4519b40b3b 100644 
--- a/src/fixed-dtoa.cc
+++ b/src/fixed-dtoa.cc
@@ -2,9 +2,10 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

+#include <stdint.h>
+
 #include <cmath>

-#include "include/v8stdint.h"
 #include "src/base/logging.h"
 #include "src/utils.h"

Index: src/globals.h
diff --git a/src/globals.h b/src/globals.h
index 0e6fcae9d7480deab1be7ea35a2132e3aaa04bf7..919d9de6ae99b6c1babb3b237f931847e481145f 100644 
--- a/src/globals.h
+++ b/src/globals.h
@@ -5,7 +5,8 @@
 #ifndef V8_GLOBALS_H_
 #define V8_GLOBALS_H_

-#include "include/v8stdint.h"
+#include <stddef.h>
+#include <stdint.h>

 #include "src/base/build_config.h"
 #include "src/base/logging.h"
Index: src/preparse-data.cc
diff --git a/src/preparse-data.cc b/src/preparse-data.cc
index 15509c02919f148faa87edd5ba6b4b0d01c5756f..c101493c9f924d22a934128db77c2fa5c8eaf4a0 100644 
--- a/src/preparse-data.cc
+++ b/src/preparse-data.cc
@@ -2,7 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-#include "include/v8stdint.h"
 #include "src/base/logging.h"
 #include "src/compiler.h"
 #include "src/globals.h"
Index: src/preparser.cc
diff --git a/src/preparser.cc b/src/preparser.cc
index 65a45b4d73619cf1e7cb6145716128898e28530f..a75ff309eed8feda766d6fd016c11a8f2ba1f47e 100644 
--- a/src/preparser.cc
+++ b/src/preparser.cc
@@ -4,8 +4,6 @@

 #include <cmath>

-#include "include/v8stdint.h"
-
 #include "src/allocation.h"
 #include "src/base/logging.h"
 #include "src/conversions-inl.h"
Index: src/scanner.cc
diff --git a/src/scanner.cc b/src/scanner.cc
index 72874aacaea5e982ce6bc80471e7c0c282677748..0709939dbac8b142a3ad81a2ea948fa681179b34 100644 
--- a/src/scanner.cc
+++ b/src/scanner.cc
@@ -4,11 +4,12 @@

 // Features shared by parsing and pre-parsing scanners.

+#include <stdint.h>
+
 #include <cmath>

 #include "src/v8.h"

-#include "include/v8stdint.h"
 #include "src/ast-value-factory.h"
 #include "src/char-predicates-inl.h"
 #include "src/conversions-inl.h"
Index: src/token.cc
diff --git a/src/token.cc b/src/token.cc
index 5dc67bb72128e8cc1b2cd12d6d4d6ada3ab2c36b..db8827102b9172fef24bdedfea38afd06290e5a1 100644 
--- a/src/token.cc
+++ b/src/token.cc
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-#include "include/v8stdint.h"
+#include <stdint.h>
 #include "src/token.h"

 namespace v8 {
Index: test/cctest/test-platform.cc
diff --git a/test/cctest/test-platform.cc b/test/cctest/test-platform.cc
index 100a5a78cf5b10054b81f0cbe296b1c92fcda490..90926d1a9626b7046331f574463f6f8961fadfea 100644 
--- a/test/cctest/test-platform.cc
+++ b/test/cctest/test-platform.cc
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-#include "include/v8stdint.h"
+#include <stdint.h>
 #include "src/base/build_config.h"
 #include "src/base/platform/platform.h"
 #include "test/cctest/cctest.h"
Index: test/unittests/base/division-by-constant-unittest.cc
diff --git a/test/unittests/base/division-by-constant-unittest.cc b/test/unittests/base/division-by-constant-unittest.cc index 47c24834dbbbd588c344605af5a6ee0d8373a23d..58816db79e87b85ee24e322f39caa4695737ce92 100644 
--- a/test/unittests/base/division-by-constant-unittest.cc
+++ b/test/unittests/base/division-by-constant-unittest.cc
@@ -6,6 +6,8 @@

 #include "src/base/division-by-constant.h"

+#include <stdint.h>
+
 #include <ostream>  // NOLINT

 #include "testing/gtest-support.h"
Index: test/unittests/base/flags-unittest.cc
diff --git a/test/unittests/base/flags-unittest.cc b/test/unittests/base/flags-unittest.cc index a1d6f3703a175105b241f673225a197727286146..6f19399dc21b3665be213f581323fbb80526f7ce 100644 
--- a/test/unittests/base/flags-unittest.cc
+++ b/test/unittests/base/flags-unittest.cc
@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.

-#include "include/v8stdint.h"
+#include <stdint.h>
 #include "src/base/flags.h"
 #include "testing/gtest/include/gtest/gtest.h"

Index: testing/gtest-support.h
diff --git a/testing/gtest-support.h b/testing/gtest-support.h
index 7be79b521f86d9d527813e6dc44ef1ab38e44c78..04daa55edcf211dbba01a6e01aef03ee6e8d773f 100644 
--- a/testing/gtest-support.h
+++ b/testing/gtest-support.h
@@ -5,7 +5,7 @@
 #ifndef V8_TESTING_GTEST_SUPPORT_H_
 #define V8_TESTING_GTEST_SUPPORT_H_

-#include "include/v8stdint.h"
+#include <stddef.h>
 #include "testing/gtest/include/gtest/gtest.h"

 namespace testing {


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group. 
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to