Reviewers: mvstanton,
Message:
Found these while poking at the prototype performance bug.
Description:
Fix {get,set}ter-on-elements tests to run through all creation functions
setter-on-elements had the wrong length hardcoded in a for loop over the
creation functions (getter-on-elements had the right length, but seemed
worth future-proofing).
Please review this at https://codereview.chromium.org/643143005/
Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+3, -3 lines):
M test/mjsunit/getters-on-elements.js
M test/mjsunit/setters-on-elements.js
Index: test/mjsunit/getters-on-elements.js
diff --git a/test/mjsunit/getters-on-elements.js
b/test/mjsunit/getters-on-elements.js
index
3bc360f14377e3443699a56d55a523c84f141a99..7f2c98b2e7f9f5934c8e6e4f391ab39fe57981a2
100644
--- a/test/mjsunit/getters-on-elements.js
+++ b/test/mjsunit/getters-on-elements.js
@@ -176,7 +176,7 @@ var cf = [create_func_smi,
create_func_double,
create_func_fast];
-for(var c = 0; c < 3; c++) {
+for(var c = 0; c < cf.length; c++) {
base_getter_test(cf[c]);
}
Index: test/mjsunit/setters-on-elements.js
diff --git a/test/mjsunit/setters-on-elements.js
b/test/mjsunit/setters-on-elements.js
index
dd3fabf3090c4452b2aa40e20e1e9fe269a41868..001906c2906784ace19317b9731ec3d42107355a
100644
--- a/test/mjsunit/setters-on-elements.js
+++ b/test/mjsunit/setters-on-elements.js
@@ -191,8 +191,8 @@ var cf = [create_func_smi,
var values = [3, 3.5, true];
-for(var c = 0; c < 3; c++) {
- for(var s = 0; s < 3; s++) {
+for(var c = 0; c < cf.length; c++) {
+ for(var s = 0; s < values.length; s++) {
base_setter_test(cf[c], 0, values[s]);
base_setter_test(cf[c], 1, values[s]);
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
