Revision: 24793
Author: [email protected]
Date: Wed Oct 22 08:06:43 2014 UTC
Log: Spread the knowledge!
[email protected], [email protected]
Review URL: https://codereview.chromium.org/670623005
https://code.google.com/p/v8/source/detail?r=24793
Modified:
/branches/bleeding_edge/src/arm/full-codegen-arm.cc
/branches/bleeding_edge/src/arm64/full-codegen-arm64.cc
/branches/bleeding_edge/src/hydrogen.cc
/branches/bleeding_edge/src/ia32/full-codegen-ia32.cc
/branches/bleeding_edge/src/mips/full-codegen-mips.cc
/branches/bleeding_edge/src/x64/full-codegen-x64.cc
/branches/bleeding_edge/src/x87/full-codegen-x87.cc
=======================================
--- /branches/bleeding_edge/src/arm/full-codegen-arm.cc Mon Oct 20 11:42:56
2014 UTC
+++ /branches/bleeding_edge/src/arm/full-codegen-arm.cc Wed Oct 22 08:06:43
2014 UTC
@@ -1726,6 +1726,8 @@
DCHECK(!CompileTimeValue::IsCompileTimeValue(property->value()));
// Fall through.
case ObjectLiteral::Property::COMPUTED:
+ // It is safe to use [[Put]] here because the boilerplate already
+ // contains computed properties with an uninitialized value.
if (key->value()->IsInternalizedString()) {
if (property->emit_store()) {
VisitForAccumulatorValue(value);
=======================================
--- /branches/bleeding_edge/src/arm64/full-codegen-arm64.cc Tue Oct 21
12:16:37 2014 UTC
+++ /branches/bleeding_edge/src/arm64/full-codegen-arm64.cc Wed Oct 22
08:06:43 2014 UTC
@@ -1706,6 +1706,8 @@
DCHECK(!CompileTimeValue::IsCompileTimeValue(property->value()));
// Fall through.
case ObjectLiteral::Property::COMPUTED:
+ // It is safe to use [[Put]] here because the boilerplate already
+ // contains computed properties with an uninitialized value.
if (key->value()->IsInternalizedString()) {
if (property->emit_store()) {
VisitForAccumulatorValue(value);
=======================================
--- /branches/bleeding_edge/src/hydrogen.cc Tue Oct 21 13:04:51 2014 UTC
+++ /branches/bleeding_edge/src/hydrogen.cc Wed Oct 22 08:06:43 2014 UTC
@@ -5621,6 +5621,8 @@
DCHECK(!CompileTimeValue::IsCompileTimeValue(value));
// Fall through.
case ObjectLiteral::Property::COMPUTED:
+ // It is safe to use [[Put]] here because the boilerplate already
+ // contains computed properties with an uninitialized value.
if (key->value()->IsInternalizedString()) {
if (property->emit_store()) {
CHECK_ALIVE(VisitForValue(value));
=======================================
--- /branches/bleeding_edge/src/ia32/full-codegen-ia32.cc Mon Oct 20
11:42:56 2014 UTC
+++ /branches/bleeding_edge/src/ia32/full-codegen-ia32.cc Wed Oct 22
08:06:43 2014 UTC
@@ -1657,6 +1657,8 @@
DCHECK(!CompileTimeValue::IsCompileTimeValue(value));
// Fall through.
case ObjectLiteral::Property::COMPUTED:
+ // It is safe to use [[Put]] here because the boilerplate already
+ // contains computed properties with an uninitialized value.
if (key->value()->IsInternalizedString()) {
if (property->emit_store()) {
VisitForAccumulatorValue(value);
=======================================
--- /branches/bleeding_edge/src/mips/full-codegen-mips.cc Mon Oct 20
11:42:56 2014 UTC
+++ /branches/bleeding_edge/src/mips/full-codegen-mips.cc Wed Oct 22
08:06:43 2014 UTC
@@ -1711,6 +1711,8 @@
DCHECK(!CompileTimeValue::IsCompileTimeValue(property->value()));
// Fall through.
case ObjectLiteral::Property::COMPUTED:
+ // It is safe to use [[Put]] here because the boilerplate already
+ // contains computed properties with an uninitialized value.
if (key->value()->IsInternalizedString()) {
if (property->emit_store()) {
VisitForAccumulatorValue(value);
=======================================
--- /branches/bleeding_edge/src/x64/full-codegen-x64.cc Mon Oct 20 11:42:56
2014 UTC
+++ /branches/bleeding_edge/src/x64/full-codegen-x64.cc Wed Oct 22 08:06:43
2014 UTC
@@ -1691,6 +1691,8 @@
DCHECK(!CompileTimeValue::IsCompileTimeValue(value));
// Fall through.
case ObjectLiteral::Property::COMPUTED:
+ // It is safe to use [[Put]] here because the boilerplate already
+ // contains computed properties with an uninitialized value.
if (key->value()->IsInternalizedString()) {
if (property->emit_store()) {
VisitForAccumulatorValue(value);
=======================================
--- /branches/bleeding_edge/src/x87/full-codegen-x87.cc Tue Oct 21 08:28:00
2014 UTC
+++ /branches/bleeding_edge/src/x87/full-codegen-x87.cc Wed Oct 22 08:06:43
2014 UTC
@@ -1646,6 +1646,8 @@
DCHECK(!CompileTimeValue::IsCompileTimeValue(value));
// Fall through.
case ObjectLiteral::Property::COMPUTED:
+ // It is safe to use [[Put]] here because the boilerplate already
+ // contains computed properties with an uninitialized value.
if (key->value()->IsInternalizedString()) {
if (property->emit_store()) {
VisitForAccumulatorValue(value);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
