http://codereview.chromium.org/209048/diff/4002/4005
File src/x64/macro-assembler-x64.cc (right):

http://codereview.chromium.org/209048/diff/4002/4005#newcode526
Line 526: Condition are_greater_equal = CheckSmiEqualsConstant(src,
constant);
On 2009/09/23 12:45:30, Lasse Reichstein wrote:
> Keep it.
> I'll refactor it anyway, when I merge it with my current work.

Done.

http://codereview.chromium.org/209048/diff/4002/4005#newcode618
Line 618: andl(src, Immediate(static_cast<uint32_t>(0x80000000u)));
On 2009/09/23 12:46:46, Lasse Reichstein wrote:
> Come to think of it, use:
>   testl(src, src);
>   return not_negative;


Done.

http://codereview.chromium.org/209048

--~--~---------~--~----~------------~-------~--~----~
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to