LGTM. Please keep the CL that this depends on separate.
https://codereview.chromium.org/656423004/diff/1/test/mjsunit/array-shift2.js
File test/mjsunit/array-shift2.js (right):
https://codereview.chromium.org/656423004/diff/1/test/mjsunit/array-shift2.js#newcode16
test/mjsunit/array-shift2.js:16: assertEquals(["element 1","element 1"],
test(["0",,2]));
suggestion: It would be nice to also verify that a[0] is an own property
whereas a[1] is not. Or alternatively we could verify that the setter in
the prototype has been invoked.
https://codereview.chromium.org/656423004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
