Can we split up this CL into several ones? As you've already mentioned, it
consists of 4 parts plus actually removing AstConstructionVisitor. Having
several CLs is a bit more tedious, but much easier to review (some CLs are
probably easy and non-controversial), debug and analyze if there are any
regressions.
https://codereview.chromium.org/660083005/diff/1/src/ast-numbering.cc
File src/ast-numbering.cc (right):
https://codereview.chromium.org/660083005/diff/1/src/ast-numbering.cc#newcode559
src/ast-numbering.cc:559: Handle<SharedFunctionInfo> shared, Zone* zone)
{
I don't think this actually belongs here: It just copies from the
FunctionLiteral to the SharedFunctionInfo. Perhaps this should live in
SharedFunctionInfo or even in some yet-to-be-implemented part of the
compilation pipeline (frontend). Anyway, having another Renumber method
is just confusing.
https://codereview.chromium.org/660083005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
