lgtm
https://codereview.chromium.org/669133003/diff/1/src/snapshot-source-sink.h
File src/snapshot-source-sink.h (right):
https://codereview.chromium.org/669133003/diff/1/src/snapshot-source-sink.h#newcode74
src/snapshot-source-sink.h:74: explicit SnapshotByteSink(int
initial_size) : data_(initial_size) {}
super nitpick: The destructor is non-trivial, since the class has a
non-POD member it needs to destroy. The style guide allows to let the
compiler generate it or to write it out, but it seems we mostly do the
latter:
https://code.google.com/p/chromium/codesearch#search/&q=%5E%5C%20*~.*%7B%5C%20*%7D%20file:src/v8/&sq=package:chromium&type=cs
Anyways... no big deal either way, and entirely your choice.
https://codereview.chromium.org/669133003/diff/1/src/snapshot-source-sink.h#newcode76
src/snapshot-source-sink.h:76: void Put(byte b, const char* description)
{ data_.Add(b); }
[here and below:]
The "description" params were potentially used by debugging code, but I
guess this change removes that option. Maybe we can remove them
entirely?
https://codereview.chromium.org/669133003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
