Revision: 24820
Author: [email protected]
Date: Thu Oct 23 07:34:36 2014 UTC
Log: [turbofan] Currently we cannot handle typed arrays bigger than
2GiB.
[email protected]
Review URL: https://codereview.chromium.org/676643002
https://code.google.com/p/v8/source/detail?r=24820
Modified:
/branches/bleeding_edge/src/compiler/js-typed-lowering.cc
=======================================
--- /branches/bleeding_edge/src/compiler/js-typed-lowering.cc Thu Oct 16
11:31:00 2014 UTC
+++ /branches/bleeding_edge/src/compiler/js-typed-lowering.cc Thu Oct 23
07:34:36 2014 UTC
@@ -566,7 +566,8 @@
if (IsExternalArrayElementsKind(array->map()->elements_kind())) {
ExternalArrayType type = array->type();
uint32_t byte_length;
- if (array->byte_length()->ToUint32(&byte_length)) {
+ if (array->byte_length()->ToUint32(&byte_length) &&
+ byte_length <= static_cast<uint32_t>(kMaxInt)) {
Handle<ExternalArray> elements =
Handle<ExternalArray>::cast(handle(array->elements()));
Node* pointer = jsgraph()->IntPtrConstant(
@@ -603,7 +604,8 @@
if (IsExternalArrayElementsKind(array->map()->elements_kind())) {
ExternalArrayType type = array->type();
uint32_t byte_length;
- if (array->byte_length()->ToUint32(&byte_length)) {
+ if (array->byte_length()->ToUint32(&byte_length) &&
+ byte_length <= static_cast<uint32_t>(kMaxInt)) {
Handle<ExternalArray> elements =
Handle<ExternalArray>::cast(handle(array->elements()));
Node* pointer = jsgraph()->IntPtrConstant(
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
