I really like the new classes.
LGTM.
https://codereview.chromium.org/645533003/diff/20001/src/serialize.h
File src/serialize.h (right):
https://codereview.chromium.org/645533003/diff/20001/src/serialize.h#newcode265
src/serialize.h:265: DisallowHeapAllocation no_allocation_;
I like this use of DisallowHeapAllocation, neat!
https://codereview.chromium.org/645533003/diff/20001/src/serialize.h#newcode528
src/serialize.h:528: void SerializePrologue(AllocationSpace space, int
size, Map* map);
+1 for use of the enum instead of int.
https://codereview.chromium.org/645533003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
