lgtm.
https://codereview.chromium.org/669053002/diff/300001/src/compiler/pipeline-statistics.cc
File src/compiler/pipeline-statistics.cc (right):
https://codereview.chromium.org/669053002/diff/300001/src/compiler/pipeline-statistics.cc#newcode16
src/compiler/pipeline-statistics.cc:16: scope_.Reset(new
ZonePool::StatsScope(pipeline_stats->zone_pool_));
This dynamic allocation is a bit ugly, but I do not see how to get rid
of this easily.
https://codereview.chromium.org/669053002/diff/300001/src/isolate.h
File src/isolate.h (right):
https://codereview.chromium.org/669053002/diff/300001/src/isolate.h#newcode387
src/isolate.h:387: V(CompilationStatistics*, tstatistics, NULL)
\
Could you rename to turbo_statistics?
https://codereview.chromium.org/669053002/diff/300001/src/isolate.h#newcode1056
src/isolate.h:1056: CompilationStatistics* GetTStatistics();
GetTurboStatistics?
https://codereview.chromium.org/669053002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
