https://codereview.chromium.org/636283009/diff/100001/src/compiler/representation-change.h
File src/compiler/representation-change.h (right):
https://codereview.chromium.org/636283009/diff/100001/src/compiler/representation-change.h#newcode237
src/compiler/representation-change.h:237: op =
machine()->TruncateFloat64ToInt32();
On 2014/10/23 10:33:26, Benedikt Meurer wrote:
The op is always the same in the end, probably no need to assign it
inside the
conditional blocks.
While that's true, I would prefer to keep this separate.
https://codereview.chromium.org/636283009/diff/100001/src/compiler/typer.cc
File src/compiler/typer.cc (right):
https://codereview.chromium.org/636283009/diff/100001/src/compiler/typer.cc#newcode1090
src/compiler/typer.cc:1090: for (auto i =
typer_->weaken_min_limits_.begin();
On 2014/10/23 10:33:26, Benedikt Meurer wrote:
range based for loops: for (const auto val : weaken_min_limits_) {...}
Done.
https://codereview.chromium.org/636283009/diff/100001/src/compiler/typer.cc#newcode1103
src/compiler/typer.cc:1103: for (auto i =
typer_->weaken_max_limits_.begin();
On 2014/10/23 10:33:26, Benedikt Meurer wrote:
range based for loops: for (const auto val : weaken_max_limits_) {...}
Done.
https://codereview.chromium.org/636283009/diff/100001/test/cctest/types-fuzz.h
File test/cctest/types-fuzz.h (right):
https://codereview.chromium.org/636283009/diff/100001/test/cctest/types-fuzz.h#newcode106
test/cctest/types-fuzz.h:106: Integer =
Type::Range(isolate->factory()->NewNumber(-V8_INFINITY),
On 2014/10/23 10:33:26, Benedikt Meurer wrote:
Shouldn't that be -inf..inf ?
Indeed... Great catch!
https://codereview.chromium.org/636283009/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
