Honestly I'd rather wait for Turbofan to catch up. There we can do proper
escape
analysis on the arguments object. Then we can just support passing it to
slice.
The reason why I find it brittle is that, suppose we implement full slice
with
support for slice range in Crankshaft. The arguments object isn't passed as
the
receiver, but as one of the range ends. That would do an implicit ToNumber
on
the arguments object, which internally calls valueOf on arguments, which
leaks
the object.
Of course currently we don't do any of that, so it could be safe for now.
I'm
not sure it's, at this time, worth the investment and possible fallout.
https://codereview.chromium.org/330303002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
