PTAL, addressed comments and added a bunch more tests.
https://codereview.chromium.org/665223006/diff/1/src/compiler/control-reducer.cc
File src/compiler/control-reducer.cc (right):
https://codereview.chromium.org/665223006/diff/1/src/compiler/control-reducer.cc#newcode239
src/compiler/control-reducer.cc:239: for (InputIter i =
node->inputs().begin(); i != node->inputs().end(); ++i) {
On 2014/10/23 10:45:25, Benedikt Meurer wrote:
for (Node* const input : node->inputs()) if (Recurse(input)) return;
Done.
https://codereview.chromium.org/665223006/diff/1/src/compiler/control-reducer.cc#newcode248
src/compiler/control-reducer.cc:248: CHECK_EQ(height, stack_.size());
On 2014/10/23 10:45:25, Benedikt Meurer wrote:
Windows builder will probably complain about this comparison. How
about some try
jobs?
Fixed with static_cast
https://codereview.chromium.org/665223006/diff/1/src/compiler/control-reducer.cc#newcode369
src/compiler/control-reducer.cc:369: ZoneDeque<Node*> phis(zone_);
On 2014/10/23 10:45:25, Benedikt Meurer wrote:
Hm, I'd like to have a ZoneStack here, i.e. a class for
std::stack<ZoneDeque>
Order doesn't really matter here, so I could as well use NodeVector.
https://codereview.chromium.org/665223006/diff/1/src/compiler/control-reducer.cc#newcode370
src/compiler/control-reducer.cc:370: for (UseIter i =
node->uses().begin(); i != node->uses().end(); ++i) {
On 2014/10/23 10:45:25, Benedikt Meurer wrote:
for (Node* const to : node->uses()) { ... }
Done.
https://codereview.chromium.org/665223006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
