LGTM, just a coupl'a nits.
https://codereview.chromium.org/662513005/diff/100001/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (right):
https://codereview.chromium.org/662513005/diff/100001/src/compiler/pipeline.cc#newcode117
src/compiler/pipeline.cc:117: typer_ = NULL;
If the schedule lives in the graph-zone, then we should also set the
schedule to NULL here.
https://codereview.chromium.org/662513005/diff/100001/src/compiler/pipeline.cc#newcode137
src/compiler/pipeline.cc:137: // graph_zone_ contains everything up to
instruction_zone_.
As discussed offline: Can we make the comment here a little clearer? It
should state that everything in this block dies when the graph zone is
deleted.
https://codereview.chromium.org/662513005/diff/100001/src/compiler/pipeline.cc#newcode148
src/compiler/pipeline.cc:148:
Likewise we should add a comment here stating that everything in this
block dies when the instruction zone is deleted.
https://codereview.chromium.org/662513005/diff/100001/src/compiler/pipeline.h
File src/compiler/pipeline.h (right):
https://codereview.chromium.org/662513005/diff/100001/src/compiler/pipeline.h#newcode29
src/compiler/pipeline.h:29: class PipelineData;
nit: Please alpha-sort.
https://codereview.chromium.org/662513005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
