https://codereview.chromium.org/671633004/diff/1/src/serialize.cc
File src/serialize.cc (right):
https://codereview.chromium.org/671633004/diff/1/src/serialize.cc#newcode1635
src/serialize.cc:1635: for (int i = 0; i < padding_size; i++)
sink_->PutSection(0, "StringPadding");
On 2014/10/23 16:48:44, vogelheim wrote:
If I get this correctly, this makes sure that you can use PutRaw
(rather than
many 1-byte PutSection) but maintain correct padding. An alternative
might be to
add SnapshotByteSink::PutRawPadded, which hides this and returns the
actual
number of bytes written. Then you could just call PutRawPadded, and
DCHECK
whether the return value matches bytes_to_output.
As usual... you decide. :)
This is a single use case, so I'd leave it at this.
https://codereview.chromium.org/671633004/diff/1/test/cctest/test-serialize.cc
File test/cctest/test-serialize.cc (right):
https://codereview.chromium.org/671633004/diff/1/test/cctest/test-serialize.cc#newcode1057
test/cctest/test-serialize.cc:1057: STATIC_CHAR_VECTOR(""), 999999);
On 2014/10/23 16:48:44, vogelheim wrote:
What's the significance of this change? Is this meant to trigger the
padding
logic, since this string would now require padding?
yes.
https://codereview.chromium.org/671633004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
