On 2014/10/24 08:34:35, Yang wrote:
On 2014/10/24 08:04:01, Sven Panne wrote:
> NOT LGTM.
>
> https://codereview.chromium.org/663893004/diff/1/src/list-inl.h
> File src/list-inl.h (right):
>
>
https://codereview.chromium.org/663893004/diff/1/src/list-inl.h#newcode36
> src/list-inl.h:36: if (std::is_fundamental<T>::value) {
> std:is_fundamental is a C++11 header feature, so we can't use that for
now.
Implemented a replacement. Please review again.
moved it to src/base/macros.h as discussed.
https://codereview.chromium.org/663893004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.