Reviewers: Weiliang, mvstanton,
Message:
WL.
PTAL.
thanks
Description:
X87: ReceiverCheckMode needs to be utilized further.
port r24704.
original commit message:
ReceiverCheckMode needs to be utilized further.
The parameter wasn't being passed appropriately, and there was an extra
opportunity to use mode RECEIVER_IS_STRING in SubStringStub.
BUG=
Please review this at https://codereview.chromium.org/664973002/
Base URL: https://chromium.googlesource.com/external/v8.git@bleeding_edge
Affected files (+3, -4 lines):
M src/x87/code-stubs-x87.cc
Index: src/x87/code-stubs-x87.cc
diff --git a/src/x87/code-stubs-x87.cc b/src/x87/code-stubs-x87.cc
index
690c3700c47bc300f534941663b386b90a287ebb..946eda2a3a62f3d6d78f5d8838cacf1eff0a56ec
100644
--- a/src/x87/code-stubs-x87.cc
+++ b/src/x87/code-stubs-x87.cc
@@ -382,8 +382,6 @@ void LoadIndexedStringStub::Generate(MacroAssembler*
masm) {
Register result = eax;
DCHECK(!result.is(scratch));
- // TODO(mvstanton): the generator doesn't need to verify that
- // receiver is a string map, that is done outside the handler.
StringCharAtGenerator char_at_generator(receiver, index, scratch, result,
&miss, // When not a string.
&miss, // When not a number.
@@ -2848,8 +2846,9 @@ void SubStringStub::Generate(MacroAssembler* masm) {
// ebx: instance type
// ecx: sub string length (smi)
// edx: from index (smi)
- StringCharAtGenerator generator(
- eax, edx, ecx, eax, &runtime, &runtime, &runtime,
STRING_INDEX_IS_NUMBER);
+ StringCharAtGenerator generator(eax, edx, ecx, eax, &runtime, &runtime,
+ &runtime, STRING_INDEX_IS_NUMBER,
+ RECEIVER_IS_STRING);
generator.GenerateFast(masm);
__ ret(3 * kPointerSize);
generator.SkipSlow(masm, &runtime);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
