Revision: 24883
Author: [email protected]
Date: Fri Oct 24 18:04:03 2014 UTC
Log: Widen definition of %HasComplexElements() to include
non-enumerability
This avoids using the Sparse methods on objects with non-enumerable
elements,
which can cause the 'enumerable: false' bit to get lost in the operation.
[email protected]
Review URL: https://codereview.chromium.org/672323003
https://code.google.com/p/v8/source/detail?r=24883
Added:
/branches/bleeding_edge/test/mjsunit/regress/regress-shift-enumerable.js
Modified:
/branches/bleeding_edge/src/objects.cc
/branches/bleeding_edge/src/objects.h
=======================================
--- /dev/null
+++
/branches/bleeding_edge/test/mjsunit/regress/regress-shift-enumerable.js
Fri Oct 24 18:04:03 2014 UTC
@@ -0,0 +1,16 @@
+// Copyright 2014 the V8 project authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+var arr = [1, 2];
+Object.defineProperty(arr, 0xfffe, {
+ value: 3,
+ configurable: true,
+ writable: true,
+ enumerable: false
+});
+arr[0xffff] = 4;
+arr.shift();
+var desc = Object.getOwnPropertyDescriptor(arr, 0xfffe);
+assertEquals(4, desc.value);
+assertFalse(desc.enumerable);
=======================================
--- /branches/bleeding_edge/src/objects.cc Fri Oct 24 12:36:45 2014 UTC
+++ /branches/bleeding_edge/src/objects.cc Fri Oct 24 18:04:03 2014 UTC
@@ -15295,7 +15295,7 @@
if (details.IsDeleted()) continue;
if (details.type() == CALLBACKS) return true;
PropertyAttributes attr = details.attributes();
- if (attr & (READ_ONLY | DONT_DELETE)) return true;
+ if (attr & (READ_ONLY | DONT_DELETE | DONT_ENUM)) return true;
}
}
return false;
=======================================
--- /branches/bleeding_edge/src/objects.h Fri Oct 24 12:36:45 2014 UTC
+++ /branches/bleeding_edge/src/objects.h Fri Oct 24 18:04:03 2014 UTC
@@ -3551,7 +3551,7 @@
int NumberOfEnumElements();
// Returns true if the dictionary contains any elements that are
non-writable,
- // non-configurable, or have getters/setters.
+ // non-configurable, non-enumerable, or have getters/setters.
bool HasComplexElements();
enum SortMode { UNSORTED, SORTED };
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
