LGTM with comments.
https://codereview.chromium.org/644083003/diff/160001/src/compiler/graph-builder.cc
File src/compiler/graph-builder.cc (right):
https://codereview.chromium.org/644083003/diff/160001/src/compiler/graph-builder.cc#newcode143
src/compiler/graph-builder.cc:143: graph()->NewNode(common()->Merge(1),
arraysize(inputs), inputs, true);
suggestion: Having the "incomplete" parameter (with default value) on
the one-operand NewNode method might slightly increase readability.
https://codereview.chromium.org/644083003/diff/160001/src/compiler/graph-builder.cc#newcode216
src/compiler/graph-builder.cc:216: control = graph()->NewNode(op,
arraysize(inputs), inputs, true);
suggestion: Having the "incomplete" parameter (with default value) on
the two-operand NewNode method might slightly increase readability.
https://codereview.chromium.org/644083003/diff/160001/src/compiler/graph.cc
File src/compiler/graph.cc (right):
https://codereview.chromium.org/644083003/diff/160001/src/compiler/graph.cc#newcode38
src/compiler/graph.cc:38: if (!incomplete &&
!IrOpcode::IsControlOpcode(result->opcode())) {
Is there a particular reason not to decorate control nodes?
https://codereview.chromium.org/644083003/diff/160001/test/unittests/compiler/value-numbering-reducer-unittest.cc
File test/unittests/compiler/value-numbering-reducer-unittest.cc
(right):
https://codereview.chromium.org/644083003/diff/160001/test/unittests/compiler/value-numbering-reducer-unittest.cc#newcode71
test/unittests/compiler/value-numbering-reducer-unittest.cc:71:
static_cast<Operator::Opcode>(IrOpcode::kLast - i);
Is there any particular reason for this change? I actually would like to
get rid of IrOpcode::kLast completely if we can, it's only used in one
assertion AFAICT.
https://codereview.chromium.org/644083003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
