Reviewers: loislo,
Description:
Make all references from root shortcuts (except one to GC roots)
Eventually we are going to nuke this shortcuts from root entry altogether.
This
fix makes (GC roots) retained size equal to the snapshot's total size.
BUG=chromium:414190
Please review this at https://codereview.chromium.org/681743002/
Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+2, -2 lines):
M src/heap-snapshot-generator.cc
Index: src/heap-snapshot-generator.cc
diff --git a/src/heap-snapshot-generator.cc b/src/heap-snapshot-generator.cc
index
680e1cc4ad74b748aca7952dc30672973a2eae08..92ec8354628716621142479a88f45b5cb64f3cc9
100644
--- a/src/heap-snapshot-generator.cc
+++ b/src/heap-snapshot-generator.cc
@@ -2517,8 +2517,8 @@ void
NativeObjectsExplorer::SetRootNativeRootsReference() {
HeapEntry* group_entry =
filler_->FindOrAddEntry(group_info, native_entries_allocator_);
DCHECK(group_entry != NULL);
- filler_->SetIndexedAutoIndexReference(
- HeapGraphEdge::kElement,
+ filler_->SetNamedAutoIndexReference(
+ HeapGraphEdge::kShortcut,
snapshot_->root()->index(),
group_entry);
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
