Reviewers: loislo, Yang,
Message:
Committed patchset #1 (id:1) manually as 24903 (presubmit successful).
Description:
Revert "Make all references from root shortcuts (except one to GC roots)"
This reverts commit 940418d2e1150499a28cca60b5dd138d351ec652. It resulted in
orphan (Document DOM trees) and (Detached DOM trees) nodes.
BUG=chromium:414190
LOG=N
[email protected], [email protected]
Committed: https://code.google.com/p/v8/source/detail?r=24903
Please review this at https://codereview.chromium.org/639753007/
Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+4, -2 lines):
M src/heap-snapshot-generator.cc
Index: src/heap-snapshot-generator.cc
diff --git a/src/heap-snapshot-generator.cc b/src/heap-snapshot-generator.cc
index
6b93f71ac3f810efcc53644d0d281c665d617041..680e1cc4ad74b748aca7952dc30672973a2eae08
100644
--- a/src/heap-snapshot-generator.cc
+++ b/src/heap-snapshot-generator.cc
@@ -2517,8 +2517,10 @@ void
NativeObjectsExplorer::SetRootNativeRootsReference() {
HeapEntry* group_entry =
filler_->FindOrAddEntry(group_info, native_entries_allocator_);
DCHECK(group_entry != NULL);
- filler_->SetNamedAutoIndexReference(
- HeapGraphEdge::kShortcut, snapshot_->root()->index(), group_entry);
+ filler_->SetIndexedAutoIndexReference(
+ HeapGraphEdge::kElement,
+ snapshot_->root()->index(),
+ group_entry);
}
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
