Revision: 24906
Author: [email protected]
Date: Mon Oct 27 12:57:50 2014 UTC
Log: Remove unused return values from PreEdge visitor.
[email protected]
Review URL: https://codereview.chromium.org/679093002
https://code.google.com/p/v8/source/detail?r=24906
Modified:
/branches/bleeding_edge/src/compiler/graph-visualizer.cc
=======================================
--- /branches/bleeding_edge/src/compiler/graph-visualizer.cc Fri Oct 24
08:25:00 2014 UTC
+++ /branches/bleeding_edge/src/compiler/graph-visualizer.cc Mon Oct 27
12:57:50 2014 UTC
@@ -118,7 +118,7 @@
void Print() { const_cast<Graph*>(graph_)->VisitNodeInputsFromEnd(this);
}
- GenericGraphVisit::Control PreEdge(Node* from, int index, Node* to);
+ void PreEdge(Node* from, int index, Node* to);
private:
std::ostream& os_;
@@ -129,8 +129,7 @@
};
-GenericGraphVisit::Control JSONGraphEdgeWriter::PreEdge(Node* from, int
index,
- Node* to) {
+void JSONGraphEdgeWriter::PreEdge(Node* from, int index, Node* to) {
if (first_edge_) {
first_edge_ = false;
} else {
@@ -152,7 +151,6 @@
}
os_ << "{\"source\":" << to->id() << ",\"target\":" << from->id()
<< ",\"index\":" << index << ",\"type\":\"" << edge_type << "\"}";
- return GenericGraphVisit::CONTINUE;
}
@@ -174,7 +172,6 @@
void Print();
GenericGraphVisit::Control Pre(Node* node);
- GenericGraphVisit::Control PreEdge(Node* from, int index, Node* to);
private:
void AnnotateNode(Node* node);
@@ -219,17 +216,6 @@
}
return GenericGraphVisit::CONTINUE;
}
-
-
-GenericGraphVisit::Control GraphVisualizer::PreEdge(Node* from, int index,
- Node* to) {
- if (use_to_def_) return GenericGraphVisit::CONTINUE;
- // When going from def to use, only consider white -> other edges, which
are
- // the dead nodes that use live nodes. We're probably not interested in
- // dead nodes that only use other dead nodes.
- if (white_nodes_.count(from) > 0) return GenericGraphVisit::CONTINUE;
- return GenericGraphVisit::SKIP;
-}
static bool IsLikelyBackEdge(Node* from, int index, Node* to) {
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
